Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add replica labels to exemplar labels, only to its series labels #4223

Merged
merged 3 commits into from
May 26, 2021

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented May 11, 2021

Signed-off-by: yeya24 yb532204897@gmail.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixes #4222

This pr removes the step of adding replica labels to exemplars. Only adding replica labels to exemplars' series labels.

Verification

Signed-off-by: yeya24 <yb532204897@gmail.com>
@yeya24 yeya24 mentioned this pull request May 12, 2021
2 tasks
Signed-off-by: yeya24 <yb532204897@gmail.com>
d.Exemplars = dedupExemplars(d.Exemplars, rr.replicaLabels)
}

resp.data = dedupExemplarsSeriesLabels(resp.data, rr.replicaLabels)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused. You say:

This pr removes the step of adding replica labels to exemplars. Only adding replica labels to exemplars' series labels.

dedupExemplarsSeriesLabels deduplicates the data using the replica labels and removes those labels. Here now you are now only doing it on the series so series will be without the replica labels, and exemplars - will be with the replica labels. Shouldn't it be the other way around i.e. the deduplication should only happen on the exemplars? 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, that was my big mistake. Thanks for catching it. I should modify the code from the Prometheus proxy side.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. PTAL

@yeya24
Copy link
Contributor Author

yeya24 commented May 13, 2021

Fixed #4234 in da51e79

Signed-off-by: yeya24 <yb532204897@gmail.com>
@yeya24 yeya24 force-pushed the fix-exemplar-replica-labels branch from da51e79 to 3d508c3 Compare May 13, 2021 19:13
Copy link
Member

@onprem onprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GiedriusS GiedriusS merged commit 20e8105 into thanos-io:main May 26, 2021
Copy link

@vovanloc0798 vovanloc0798 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yeya24 yeya24 deleted the fix-exemplar-replica-labels branch May 26, 2021 15:51
@altcoinvote
Copy link

altcoinvote commented Aug 11, 2022

Coin Vote Website https://altcoinvote.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replica labels shouldn't be added to exemplar labels
5 participants