Sort flags alphabetically #4062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wiard van Rij <wiard@outlook.com>
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
bwplotka
reviewed
Apr 15, 2021
Yea, I wanted to review this first and discuss it before making it final :) |
Signed-off-by: Wiard van Rij <wiard@outlook.com>
|
I don't know why the test is failing. Local: -> Committed all the docs edit; Guess I have something odd on my machine... will manually fix this. |
Signed-off-by: Wiard van Rij <wiard@outlook.com>
|
Now all works, just flaky test, retried |
bwplotka
approved these changes
Apr 15, 2021
It's because I cannot access /tmp locally - non-root (: It makes up some funky /var directory. I manually fixed this (: |
Right, looks great! Will update the docs in #3993 and see how that goes. Thanks @wiardvanrij |
someshkoli
pushed a commit
to someshkoli/thanos
that referenced
this pull request
Apr 21, 2021
* sort flags alphabetical Signed-off-by: Wiard van Rij <wiard@outlook.com> * Update changelog, docs and rename sort function Signed-off-by: Wiard van Rij <wiard@outlook.com> * fixes docs, something odd on my machine Signed-off-by: Wiard van Rij <wiard@outlook.com> Signed-off-by: someshkoli <kolisomesh27@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wiard van Rij wiard@outlook.com
Relates to #4034
It sorts the flags alphabetical
Changes
The latest release of the kingpin package is from 17 Dec 2017. It was missing any method to do some funky stuff to get this done. That is, unless we want to manually order all flags in the code. So;
UsageFuncsbecomes availableI think this might fall under "it's not stupid if it works" but this change felt nasty lol. Open for review anyway, LMK.
Verification
Locally tested.
Will update further if this is the way to go...