Make NewInstrumentationMiddleware buckets configurable #3948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>
Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>
kakkoyun
reviewed
Mar 22, 2021
| @@ -150,7 +150,9 @@ func NewHandler(logger log.Logger, o *Options) *Handler { | |||
|
|
|||
| ins := extpromhttp.NewNopInstrumentationMiddleware() | |||
| if o.Registry != nil { | |||
| ins = extpromhttp.NewInstrumentationMiddleware(o.Registry) | |||
| ins = extpromhttp.NewInstrumentationMiddleware(o.Registry, | |||
| []float64{0.001, 0.005, 0.01, 0.02, 0.03, 0.04, 0.05, 0.06, 0.07, 0.08, 0.09, 0.1, 0.25, 0.5, 0.75, 1, 2, 3, 4, 5}, | |||
clyang82
pushed a commit
to stolostron/thanos
that referenced
this pull request
Apr 27, 2021
* Make NewInstrumentationMiddleware buckets configurable Signed-off-by: Matthias Loibl <mail@matthiasloibl.com> * Add Changelog entry for thanos-io#3948 Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Set Thanos Receive specific histogram buckets for http_duration_seconds_bucket so that we can measure Receiver latency properly. Highest bucket being 5s.
It was always 99ms during my benchmarks...
Which is unsurprising when most requests fall within the buckets
[0.01, 0.1]Verification
I can see proper p99 latencies between 10ms and 100ms now. :)