pkg/logging: Fix HTTP logging middleware panic #3922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brancz
force-pushed
the
fix-http-log-panic
branch
3 times, most recently
from
e773949
to
42e4dab
Compare
Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
brancz
force-pushed
the
fix-http-log-panic
branch
from
42e4dab
to
140f988
Compare
metalmatze
approved these changes
Mar 12, 2021
|
Looks great to me 💯 |
yashrsharma44
approved these changes
Mar 12, 2021
|
Enabling auto-merge when CI goes green :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Use
net.SplitHostPortinstead ofstrings.Splitwith a direct slice access, which caused panics when theHostheader is not available or doesn't contain a port.Verification
Added a unit test that without this patch paniced.
Fixes #3921
@thanos-io/thanos-maintainers