Support bucket rewrite relabel #3707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
yeya24
commented
Mar 9, 2021
yeya24
force-pushed
the
bucket-rewrite-relabel
branch
from
c7181bc
to
73c34e6
Compare
|
I will close this pr as I cannot figure out a way to pass the relabel test case without #3710. |
|
After some investigation, I found the root cause and I am able to fix the problem. Reopen this pr and I will try to tackle this again. |
yeya24
force-pushed
the
bucket-rewrite-relabel
branch
from
73c34e6
to
d027647
Compare
|
This pr should be ready for review. |
yeya24
force-pushed
the
bucket-rewrite-relabel
branch
from
d027647
to
bdf1241
Compare
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
yeya24
force-pushed
the
bucket-rewrite-relabel
branch
3 times, most recently
from
16abe27
to
98a38dc
Compare
onprem
previously approved these changes
May 23, 2021
|
@yeya24 Maybe let's add a CHANGELOG entry for this before merge. This is too awesome to not have a CHANGELOG 😄 |
Signed-off-by: yeya24 <yb532204897@gmail.com>
Signed-off-by: yeya24 <yb532204897@gmail.com>
Signed-off-by: yeya24 <yb532204897@gmail.com>
yeya24
force-pushed
the
bucket-rewrite-relabel
branch
from
5420332
to
f835ad2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yeya24 yb532204897@gmail.com
Fixes #3069
Add relabel support to bucket rewrite.
Changes
Add a
RelabelModifierfor blocks relabeling. Unlike the deletion modifier which is used in a streaming way,RelabelModifiercannot do this and the reasons are:These requirements mean that I have to sort almost all the things in the constructor. It is inefficient but currently I don't find a better way to solve it.
Verification
Unit tests added and manual testing.