Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added request logging for gRPC and HTTP in the server side #3361

Closed
wants to merge 55 commits into from
Closed

Added request logging for gRPC and HTTP in the server side #3361

wants to merge 55 commits into from

Commits on Feb 12, 2021

  1. Added request logging for grpc 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    2580544 View commit details
    Browse the repository at this point in the history

  2. Added request logging for grpc 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    9a25121 View commit details
    Browse the repository at this point in the history

  3. changed the logging option to log start and finish of a call 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    f525ccb View commit details
    Browse the repository at this point in the history

  4. added flags for enabling/disabling request logging for grpc 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    b6d338c View commit details
    Browse the repository at this point in the history

  5. nitpicks due to make docs 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    42d2284 View commit details
    Browse the repository at this point in the history

  6. added a changelog 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    fdbfe9a View commit details
    Browse the repository at this point in the history

  7. nitpicks 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    0633a92 View commit details
    Browse the repository at this point in the history

  8. configure option for logging 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    c5a26f1 View commit details
    Browse the repository at this point in the history

  9. changelog nitpick 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    96fa990 View commit details
    Browse the repository at this point in the history

  10. added changelog 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    d32d8f2 View commit details
    Browse the repository at this point in the history

  11. more nitpicks 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    bef9889 View commit details
    Browse the repository at this point in the history

  12. renamed requestLoggingDecision to reqLogDecision and some nitcpicks 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    623e017 View commit details
    Browse the repository at this point in the history

  13. Added the check of reusing the request-id if present 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    7d5c90b View commit details
    Browse the repository at this point in the history

  14. make docs nitpick 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    6aefc0e View commit details
    Browse the repository at this point in the history

  15. Added the default level of debug and error codes for logging 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    072c645 View commit details
    Browse the repository at this point in the history

  16. Add the levels for logging 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    4ed4410 View commit details
    Browse the repository at this point in the history

  17. Added a YAML flag for request logging config 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    5dd871b View commit details
    Browse the repository at this point in the history

  18. Changed the setup signature to accept a reqlog param to be shared amo… 

    …ng all the components of Thanos. Changed the signature of decision for logging, and pushed the new yaml config among all the middleware

Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    9b81c85 View commit details
    Browse the repository at this point in the history

  19. Updated the grpc middleware package to include the latest signature o… 

    …f the decider

Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    702cab9 View commit details
    Browse the repository at this point in the history

  20. Added new config files for YAML parsing 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    d7b592d View commit details
    Browse the repository at this point in the history

  21. changelog nitpick 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    cab016f View commit details
    Browse the repository at this point in the history

  22. linting nitpicks 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    5622a1b View commit details
    Browse the repository at this point in the history

  23. Added deprecation warning and added a function to reroute logging thr… 

    …ough one of the flags

Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    65632a2 View commit details
    Browse the repository at this point in the history

  24. docs nitpicks 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    508d187 View commit details
    Browse the repository at this point in the history

  25. bug fix for reverse logging condition 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    a44c6e1 View commit details
    Browse the repository at this point in the history

  26. fixed some bugs for evaluating the options and added a warning for de… 

    …precating flag of log.request.decision

Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    4bf9742 View commit details
    Browse the repository at this point in the history

  27. removed gophercloud from go.mod 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    6ff8d57 View commit details
    Browse the repository at this point in the history

  28. self addressed comments 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    21eac29 View commit details
    Browse the repository at this point in the history

  29. * Added a dummy variable which was used by the, to be deprecated flag… 

    … of request logging

* Added a warning that request logging is disabled for tools
* Removed a flag which is to be deprecated in the next release

Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    a762e13 View commit details
    Browse the repository at this point in the history

  30. * Added a fail-first approach if the request logging is incorrectly e… 

    …nabled.

Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    34da06d View commit details
    Browse the repository at this point in the history

  31. Renaming of functions 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    bc99e87 View commit details
    Browse the repository at this point in the history

  32. Removed indentation and simplified else conditions 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    8f4f1b1 View commit details
    Browse the repository at this point in the history

  33. break down the yaml struct for grpc and http into its individual configs 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    276f674 View commit details
    Browse the repository at this point in the history

  34. make docs nits 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    20a09d8 View commit details
    Browse the repository at this point in the history

  35. modify changelog 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    c505074 View commit details
    Browse the repository at this point in the history

  36. modified the signature of setup function to the original one 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    ef51cad View commit details
    Browse the repository at this point in the history

  37. removed the message for the flags 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    d7e0774 View commit details
    Browse the repository at this point in the history

  38. make docs nits 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    76710a6 View commit details
    Browse the repository at this point in the history

  39. Added auto generation scripts for req logging 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    bbfebb0 View commit details
    Browse the repository at this point in the history

  40. removed request logging from compactor 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    00a9788 View commit details
    Browse the repository at this point in the history

  41. remove verbose warn messages 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    1433ddc View commit details
    Browse the repository at this point in the history

  42. changed pass by value to pass by reference 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    01686d6 View commit details
    Browse the repository at this point in the history

  43. removed occurence of os.Exit 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    aa0c220 View commit details
    Browse the repository at this point in the history

  44. make docs nits 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    6e693eb View commit details
    Browse the repository at this point in the history

  45. revert compact.go to master 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    425646a View commit details
    Browse the repository at this point in the history

  46. rename ReqlogConfig to RequestConfig 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    f7e98c2 View commit details
    Browse the repository at this point in the history

  47. Added a validation check so that all the configs are checked before a… 

    … component starts

Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    a8170ab View commit details
    Browse the repository at this point in the history

  48. nits 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    2b86f64 View commit details
    Browse the repository at this point in the history

  49. Modify the message for request.logging flag for having a default valu… 

    …e as null

Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    41976b8 View commit details
    Browse the repository at this point in the history

  50. remove a line from the flags 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    c576f05 View commit details
    Browse the repository at this point in the history

  51. remove a deceptive comment 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    4f52da3 View commit details
    Browse the repository at this point in the history

  52. changed the var name to small caps 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    441caa4 View commit details
    Browse the repository at this point in the history

  53. change errors.Errorf to Wrapf for providing context to error message 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    86801c4 View commit details
    Browse the repository at this point in the history

  54. move changelog entry to unreleased tag 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    b2c01dd View commit details
    Browse the repository at this point in the history

  55. changed request.logging to request.logging in the flags 

    Signed-off-by: Yash Sharma <yashrsharma44@gmail.com>
    @yashrsharma44
    yashrsharma44 committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    e588aa1 View commit details
    Browse the repository at this point in the history