objstore/s3: Add list_objects_version to S3 config #3312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Solves #3291 |
kakkoyun
approved these changes
Oct 14, 2020
I can't see what failed here. Is it related to my code? |
bwplotka
reviewed
Oct 15, 2020
sevagh
commented
Oct 20, 2020
sevagh
changed the title
bwplotka
approved these changes
Oct 20, 2020
|
I rebased on the tip of master to fix the CHANGELOG conflict. This should be OK to merge if it passes the checks? |
bwplotka
approved these changes
Oct 26, 2020
CHANGELOG.md
Outdated
|
|
||
| ### Fixed | ||
| - [#3257](https://github.com/thanos-io/thanos/pull/3257) Ruler: Prevent Ruler from crashing when using default DNS to lookup hosts that results in "No such hosts" errors. | ||
| - [#3331](https://github.com/thanos-io/thanos/pull/3331) Disable Azure blob exception logging | ||
| - [#3341](https://github.com/thanos-io/thanos/pull/3341) Disable Azure blob syslog exception logging | ||
| - [#3276](https://github.com/thanos-io/thanos/pull/3276) Query Frontend: Support query splitting and retry for labels and series requests. |
There was a problem hiding this comment.
Hm, I think rebase went wrong here?
There was a problem hiding this comment.
The CHANGELOG looks different from the time I had to modify it: 57076a5#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
This has me confused, TBH.
There was a problem hiding this comment.
I just fixed it manually.
Signed-off-by: Sevag Hanssian <sevagh@protonmail.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sevag Hanssian sevagh@protonmail.com
Changes
I added an optional config "list_objects_version: string" to the S3 configuration.
Verification
I have a bucket in production which requires ListObjectsV1 to work (I need to deploy a custom binary with minio UseV1 set to true). After making this PR, I tested "thanos bucket tools web" with the new config option and it works.