Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rules: fix silly mistakes in the rules API #2957

Merged
merged 10 commits into from
Aug 11, 2020
Merged

rules: fix silly mistakes in the rules API #2957

merged 10 commits into from
Aug 11, 2020

Commits on Jul 29, 2020

  1. rules: fix silly mistakes in the rules API 

    Fixes thanos-io#2938 and is a follow up
to thanos-io#2925.

Changes:
* Copying all fields properly to the group-level as well
* Set TZ to UTC explicitly in other `time.Time` fields to avoid a panic
* Make sure that `RuleGroup` always has an empty array in the `rules`
field because that's customary and that is what the new React UI
expects.

Manual testing for now.

Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
    @GiedriusS
    GiedriusS committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    83068f1 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2020

  1. rules: remove DeprecatedPartialResponseStrategy 

    It has been marked deprecated for more than 2 months. Remove it finally.

Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
    @GiedriusS
    GiedriusS committed Aug 2, 2020
    Configuration menu
    Copy the full SHA
    94d7305 View commit details
    Browse the repository at this point in the history

  2. e2e: rules_api: add checks for non-zero values 

    Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
    @GiedriusS
    GiedriusS committed Aug 2, 2020
    Configuration menu
    Copy the full SHA
    08f2005 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into fixup_rules_api 

    Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
    @GiedriusS
    GiedriusS committed Aug 2, 2020
    Configuration menu
    Copy the full SHA
    5b38401 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2020

  1. test: e2e: fix rule test 

    Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
    @GiedriusS
    GiedriusS committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    663c43b View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into fixup_rules_api 

    Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
    @GiedriusS
    GiedriusS committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    00bf3ee View commit details
    Browse the repository at this point in the history

  3. test: rule: fix govet error 

    Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
    @GiedriusS
    GiedriusS committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    83bc4aa View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2020

  1. Update CHANGELOG.md 

    Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>

Co-authored-by: Lucas Servén Marín <lserven@gmail.com>
    @GiedriusS @squat
    GiedriusS and squat authored Aug 10, 2020
    Configuration menu
    Copy the full SHA
    bb19c33 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG.md 

    Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>

Co-authored-by: Lucas Servén Marín <lserven@gmail.com>
    @GiedriusS @squat
    GiedriusS and squat authored Aug 10, 2020
    Configuration menu
    Copy the full SHA
    59c2872 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into fixup_rules_api

    @GiedriusS
    GiedriusS authored Aug 10, 2020
    Configuration menu
    Copy the full SHA
    adc16e1 View commit details
    Browse the repository at this point in the history