Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix increment of thanos_compact_downsample_failures_total counter #2924

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Jul 22, 2020

Signed-off-by: Ben Ye yb532204897@gmail.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Similar to #2895, we should inc the counter metric here.

Verification

Signed-off-by: Ben Ye <yb532204897@gmail.com>
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks!

Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@kakkoyun kakkoyun merged commit 488d174 into thanos-io:master Jul 23, 2020
@yeya24 yeya24 deleted the fix-inc-downsample-failure-metric branch July 23, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants