Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CLI Flags page in React UI #2796

Merged
merged 3 commits into from
Jun 27, 2020
Merged

Implement CLI Flags page in React UI #2796

merged 3 commits into from
Jun 27, 2020

Conversation

onprem
Copy link
Member

@onprem onprem commented Jun 23, 2020

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • New API endpoint /status/flags in query to expose provided cli flags.
  • Updated thanos/Navbar.tsx in React UI to handle dropdowns as well.

Verification

Tested locally, with both development and production build.

@onprem
query: Add /status/flags endpoint
b08b897 
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
@onprem
ui: Allow dropdowns in Navbar; enable flags page
7bc6d16 
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
@bwplotka
Copy link
Member

Nice, BTW I just got idea: We could run Thanos components for UI purposes on netlfy so we can preview of all your amazing work! ❤️

@GiedriusS
Copy link
Member

Nice, BTW I just got idea: We could run Thanos components for UI purposes on netlfy so we can preview of all your amazing work! heart

We talked about this on our sync: that's definitely something we could explore but for this, a publicly available instance of Thanos Query would be needed, and that would take much more time than just deploying the resulting pages onto Netlify. 👍 Prometheus could also benefit from something like that.

GiedriusS
GiedriusS requested changes Jun 25, 2020
View reviewed changes
cmd/thanos/query.go Show resolved Hide resolved
@GiedriusS
Copy link
Member

Let's resolve the conflicts and I think this should be good to go 🎉

squat
squat approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! 🚀 🚀 🚀

@bwplotka
Copy link
Member

We talked about this on our sync: that's definitely something we could explore but for this, a publicly available instance of Thanos Query would be needed, and that would take much more time than just deploying the resulting pages onto Netlify. +1 Prometheus could also benefit from something like that.

Yes, this will need bit more work(:

@onprem
Merge branch 'master' into flags-page
be55334 
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
GiedriusS
GiedriusS approved these changes Jun 27, 2020
View reviewed changes
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@GiedriusS GiedriusS merged commit dd2e003 into thanos-io:master Jun 27, 2020
paulfantom added a commit to paulfantom/thanos that referenced this pull request Jul 9, 2020
@paulfantom
Merge remote-tracking branch 'upstream/release-0.14' into 0.14
9c227bc 
* upstream/release-0.14: (46 commits)
  Cut release v0.14.0-rc.1 (thanos-io#2853)
  Query: correctly marshal errors to JSON and ignore if nil (thanos-io#2848)
  ci: Manually download promu in crossbuild stage (thanos-io#2828)
  Cut release v0.14.0-rc.0 (thanos-io#2826)
  Soft cut changelog on master to indicate v0.14.0 being in progress (thanos-io#2824)
  Update ThanosReceiveNoUpload to select sum == 0 (thanos-io#2819)
  receive: Added more observability, fixed leaktest, to actually check leaks ): (thanos-io#2817)
  Query: always return a string in the `lastError` field (thanos-io#2809)
  Added missing CHANGELOG entry for PR 2613 (thanos-io#2820)
  receive: Fixed small options race; Removed unused StartTime feature. (thanos-io#2816)
  go.mod: Bump Prometheus to current latest (thanos-io#2814)
  Implement CLI Flags page in React UI (thanos-io#2796)
  Improve ThanosReceiveNoUpload to only alert on current instances
  store: Preallocate output buffer when encoding postings. (thanos-io#2812)
  compact: introduce flag --block-viewer.global.sync-block-interval (thanos-io#2752)
  docs: compact: add blurb about how retention policy works (thanos-io#2808)
  Reduced memory allocations in readIndexRange() (thanos-io#2807)
  ui: Add Stores page to React UI (thanos-io#2754)
  Added Kemal to Maintainer Role; Kemal is volounteering to be next release shephard (thanos-io#2804)
  proposal: Add scalable rule storage proposal (thanos-io#2661)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squat squat squat approved these changes

@GiedriusS GiedriusS GiedriusS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@onprem @bwplotka @GiedriusS @squat