store/proxy: Deduplicate chunks on StoreAPI level. Recommend chunk sorting for StoreAPI + Optimized iter chunk dedup. (#2710) #2711
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked: #2710
Also: Merge same series together on proxy level instead select. This allows better dedup efficiency.
Partially fixes: #2303
Cases like overlapped data from store and sidecar and 1:1 duplicates are optimized as soon as it's possible.
This case was highly visible on GitLab repro data and exists in most of Thanos setup.
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com
Never use proto .String() in fast path!
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com