Added logging for dns resolution error in the Query component as well #2525
Commits on May 18, 2020
-
Added logging for dns resolution error in the Query component as well
Signed-off-by: Yash <yashrsharma44@gmail.com> Nitpicking Signed-off-by: Yash <yashrsharma44@gmail.com> More nitpicking Signed-off-by: Yash <yashrsharma44@gmail.com> Removed the errorlist from lock scope for faster access Signed-off-by: Yash <yashrsharma44@gmail.com> Added tsdb.MultiError for error handling Signed-off-by: Yash <yashrsharma44@gmail.com> Fixed some import issues Signed-off-by: Yash <yashrsharma44@gmail.com> Fixed linting Signed-off-by: Yash <yashrsharma44@gmail.com> Changelog Signed-off-by: Yash <yashrsharma44@gmail.com> Linting issues Signed-off-by: Yash <yashrsharma44@gmail.com> More linting issues Signed-off-by: Yash <yashrsharma44@gmail.com> fixed import error Signed-off-by: Yash <yashrsharma44@gmail.com> Reverted some changes Signed-off-by: Yash <yashrsharma44@gmail.com> Added some more error checks Signed-off-by: Yash <yashrsharma44@gmail.com> Fixed some failing tests Signed-off-by: Yash <yashrsharma44@gmail.com> Linting Signed-off-by: Yash <yashrsharma44@gmail.com> Removed extra error param for logging Signed-off-by: Yash <yashrsharma44@gmail.com> Changelog modification Signed-off-by: Yash <yashrsharma44@gmail.com> Fixed unused variable Signed-off-by: Yash <yashrsharma44@gmail.com> Logged failed dns resolution in the memcached_client Signed-off-by: Yash <yashrsharma44@gmail.com> Changed the errorList to errs Signed-off-by: Yash <yashrsharma44@gmail.com> Changed concrete error type to primitive one Signed-off-by: Yash <yashrsharma44@gmail.com> Added logging of dns resolution failure in `http.go` Changed the error message in the `memcached_client.go` Signed-off-by: Yash <yashrsharma44@gmail.com> Removed logging of errors in . Now it would return error list, which is to be handled by the receiver Signed-off-by: Yash <yashrsharma44@gmail.com> Removed Err() method Signed-off-by: Yash <yashrsharma44@gmail.com> Fixed import errors Signed-off-by: Yash <yashrsharma44@gmail.com> Removed extra variables Signed-off-by: Yash <yashrsharma44@gmail.com> Linting Signed-off-by: Yash <yashrsharma44@gmail.com> Check to ensure that return error if list of error is non-empty Signed-off-by: Yash <yashrsharma44@gmail.com> Modified tests of provider_test.go Signed-off-by: Yash <yashrsharma44@gmail.com> more checks Signed-off-by: Yash <yashrsharma44@gmail.com>
-
Signed-off-by: Yash <yashrsharma44@gmail.com>
-
Instead of logging the error and then returning it, just return the e…
…rror Signed-off-by: Yash <yashrsharma44@gmail.com>
-
Error check for resolve method in rule.go
Signed-off-by: Yash <yashrsharma44@gmail.com>
-
Added more useful error message
Signed-off-by: Yash <yashrsharma44@gmail.com>
-
Modified errs.Err() so that it returns error if found else returns nil
Signed-off-by: Yash <yashrsharma44@gmail.com>
-
Signed-off-by: Yash <yashrsharma44@gmail.com>
-
Signed-off-by: Yash <yashrsharma44@gmail.com>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.