Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storetestutil: Added shared series helpers on BucketSeries; added ProxySeries and MultiTSDB Series benchmarks. #2305

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Mar 23, 2020

Similar to store GW Series but for proxy.

Also: * Fixed minTime for TSDB and Receiver. Now checks head block min Time as well.

Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com

@bwplotka bwplotka changed the title querier: Added ProxySeries Benchmarks. querier: Added ProxySeries and StoreSetIterators Benchmarks. Mar 27, 2020
@stale
Copy link

stale bot commented May 26, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label May 26, 2020
@bwplotka
Copy link
Member Author

Yup will finish.. at some point (:

@stale stale bot removed the stale label May 26, 2020
@bwplotka bwplotka changed the title querier: Added ProxySeries and StoreSetIterators Benchmarks. storetestutil: Added shared series helpers and ProxySeries, dedup iters Benchmarks based on that. Jul 7, 2020
@bwplotka bwplotka marked this pull request as ready for review July 7, 2020 18:50
@bwplotka bwplotka changed the title storetestutil: Added shared series helpers and ProxySeries, dedup iters Benchmarks based on that. storetestutils: Added shared series helpers and ProxySeries, dedup iters Benchmarks based on that. Jul 7, 2020
@bwplotka bwplotka force-pushed the querier-bench branch 3 times, most recently from ca55a57 to 6262c89 Compare July 8, 2020 18:00
@bwplotka bwplotka changed the title storetestutils: Added shared series helpers and ProxySeries, dedup iters Benchmarks based on that. storetestutil: Added shared series helpers on BucketSeries; added ProxySeries and MultiTSDB Series benchmarks. Jul 8, 2020
@bwplotka bwplotka requested review from brancz and squat July 8, 2020 18:00
@bwplotka
Copy link
Member Author

bwplotka commented Jul 8, 2020

This should be ready for review. Benchmarking Receive Series now.

@bwplotka
Copy link
Member Author

bwplotka commented Jul 8, 2020

Baseline on my machine for 30s test - probably worth doing longer ones.

Running BenchmarkMultiTSDBSeries run 0-receiveseries
Creating 250000 1-sample series in /tmp/testorbench-multitsdbseries443287264/0
Creating 250000 1-sample series in /tmp/testorbench-multitsdbseries443287264/1
Creating 250000 1-sample series in /tmp/testorbench-multitsdbseries443287264/2
Creating 250000 1-sample series in /tmp/testorbench-multitsdbseries443287264/3
goos: linux
goarch: amd64
pkg: github.com/thanos-io/thanos/pkg/store
BenchmarkMultiTSDBSeries/1000000SeriesWith1Samples/headOnly/4_TSDBs_with_1_samples,_250000_series_each-12         	       6	6405328704 ns/op	4077894794 B/op	44868668 allocs/op
Creating 250000 1-sample series in /tmp/testorbench-multitsdbseries458997439/0
Creating 250000 1-sample series in /tmp/testorbench-multitsdbseries458997439/1
Creating 250000 1-sample series in /tmp/testorbench-multitsdbseries458997439/2
Creating 250000 1-sample series in /tmp/testorbench-multitsdbseries458997439/3
BenchmarkMultiTSDBSeries/1000000SeriesWith1Samples/blocksOnly/4_TSDBs_with_1_samples,_250000_series_each-12       	       6	5773966111 ns/op	4076671805 B/op	44868444 allocs/op
Creating 25000 25-sample series in /tmp/testorbench-multitsdbseries842640658/0
Creating 25000 25-sample series in /tmp/testorbench-multitsdbseries842640658/1
Creating 25000 25-sample series in /tmp/testorbench-multitsdbseries842640658/2
Creating 25000 25-sample series in /tmp/testorbench-multitsdbseries842640658/3
BenchmarkMultiTSDBSeries/100000SeriesWith100Samples/headOnly/4_TSDBs_with_25_samples,_25000_series_each-12        	       9	3684722410 ns/op	1728735155 B/op	27126350 allocs/op
Creating 25000 25-sample series in /tmp/testorbench-multitsdbseries244242761/0
Creating 25000 25-sample series in /tmp/testorbench-multitsdbseries244242761/1
Creating 25000 25-sample series in /tmp/testorbench-multitsdbseries244242761/2
Creating 25000 25-sample series in /tmp/testorbench-multitsdbseries244242761/3
BenchmarkMultiTSDBSeries/100000SeriesWith100Samples/blocksOnly/4_TSDBs_with_25_samples,_25000_series_each-12      	       9	4040282723 ns/op	1664831863 B/op	27121975 allocs/op
Creating 1 2500000-sample series in /tmp/testorbench-multitsdbseries145321492/0
Creating 1 2500000-sample series in /tmp/testorbench-multitsdbseries145321492/1
Creating 1 2500000-sample series in /tmp/testorbench-multitsdbseries145321492/2
Creating 1 2500000-sample series in /tmp/testorbench-multitsdbseries145321492/3
BenchmarkMultiTSDBSeries/1SeriesWith10000000Samples/headOnly/4_TSDBs_with_2500000_samples,_1_series_each-12       	      24	1533123931 ns/op	2708868740 B/op	 1022712 allocs/op
Creating 1 2500000-sample series in /tmp/testorbench-multitsdbseries755299939/0
Creating 1 2500000-sample series in /tmp/testorbench-multitsdbseries755299939/1
Creating 1 2500000-sample series in /tmp/testorbench-multitsdbseries755299939/2
Creating 1 2500000-sample series in /tmp/testorbench-multitsdbseries755299939/3
BenchmarkMultiTSDBSeries/1SeriesWith10000000Samples/blocksOnly/4_TSDBs_with_2500000_samples,_1_series_each-12     	      20	1674253837 ns/op	2682663242 B/op	 1020595 allocs/op

…xySeries and MultiTSDB Series benchmarks.

Also:
* Fixed minTime for TSDB and Receiver. Now checks head block min Time as well.

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
@brancz
Copy link
Member

brancz commented Jul 9, 2020

re-kicked the CI job it seems like it was a flake in the reloader tests

@bwplotka bwplotka merged commit e09115a into master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants