bucket: Improve tooltip for bucket UI #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reconstructed the tooltip with bootstrap stuff to give more detailed informations about each chunks Signed-off-by: Geoffrey Beausire <g.beausire@criteo.com>
|
Cool, don't hesitate to ping me or on Slack if you get feedback |
vankop
pushed a commit
to monitoring-tools/thanos
that referenced
this pull request
Feb 28, 2020
Reconstructed the tooltip with bootstrap stuff to give more detailed informations about each chunks Signed-off-by: Geoffrey Beausire <g.beausire@criteo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #2149
Changes
I improved the tooltip on
bucket web. It was reconstructed using bootstrap tools to show much more details than before:Before
After
Verification
Visual testing only