pkg/store: Expose metric about empty stream responses in proxy store #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiedriusS
reviewed
Jan 22, 2020
pkg/store/proxy.go
Outdated
| @@ -348,6 +374,12 @@ func startStreamSeriesSet( | |||
| defer wg.Done() | |||
| defer close(s.recvCh) | |||
|
|
|||
| i := 0 | |||
There was a problem hiding this comment.
I feel like a more descriptive name like numResponses would be better. I am way too used to seeing i as a placeholder variable in for-loops for the index 😄 Here we do an infinite loop so it probably doesn't fit as well.
brancz
force-pushed
the
empty-stream-response-metric
branch
from
d572ae8
to
10e2f6e
Compare
|
There was an attempt to add a similar thing here as well: #1789 |
bwplotka
approved these changes
Jan 23, 2020
povilasv
approved these changes
Jan 23, 2020
brancz
force-pushed
the
empty-stream-response-metric
branch
from
10e2f6e
to
5a8026e
Compare
Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
brancz
force-pushed
the
empty-stream-response-metric
branch
from
5a8026e
to
63c2d53
Compare
Hence the word 'similar' 😄 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds a metric to track how often we do requests that end up in empty responses. Related to #1611.
Verification
Did queries that stores didn't have data for, and verified that indeed the
/metricsendpoint reflects this.@bwplotka @squat @GiedriusS