-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: bump minio-go to v6.0.44 #1852
Conversation
0225f52
to
8acd106
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM!
Is there something we can put in CHANGELOG for this? (: Fixed/improved something interesting for user? Looking by this contribution it has to be interesting ;p
Ha, I guess it depends on your definition of interesting. This adds support for the environment variable |
Signed-off-by: Rob Best <robertbest89@gmail.com>
8acd106
to
c284c86
Compare
Pushed an item to the CHANGELOG 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth a CHANGELOG item then (:
Thanks!
CHANGELOG'd |
Yup, seen, just waited on CI (: Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
Not enough horn touted I'm afraid. This change allows Thanos to hot reload AWS credentials. We are running Vault deployment and a side-car helper with our AWS applications. Side-car uses Kubernetes SA as identity and provision temporary AWS keys and exposes them over http on localhost. Thanos is now able to consume that http endpoint and use the temporary credentials provisioned by the sidecar. These credentials can be rotated as often as you want, 15 minutes, etc. without any disruption. |
This version includes minio/minio-go@d18cd1c, which adds functionality I would like to use with Thanos.