pkg/receive: enable forwarding metrics #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metalmatze
reviewed
Jun 11, 2019
metalmatze
suggested changes
Jun 11, 2019
brancz
reviewed
Jun 11, 2019
This commit renames `host` to `node` in the context of the receive hashring. This is because more often than not, the hashring will deal with endpoints rather than simply hosts and node is a more generic term for the operand of a hashring.
|
cc @brancz @metalmatze @bwplotka I addressed the comments you made the first time around so this is now ready for another round 💪 |
|
We had some offline discussion to change this implementation a little bit. The revised version should actually be significantly simpler. |
squat
force-pushed
the
forward
branch
2 times, most recently
from
0c187d6
to
2ae5ba7
Compare
|
@brancz all the changes we talked about today are in now. The configuration management is much simpler for hashrings now 😌. We have some boilerplate for creating a configuration file watcher, but it is sane and self-contained. |
brancz
reviewed
Jun 14, 2019
squat
force-pushed
the
forward
branch
2 times, most recently
from
388ffa4
to
251a6da
Compare
brancz
reviewed
Jun 17, 2019
squat
force-pushed
the
forward
branch
2 times, most recently
from
4122ee4
to
acc7290
Compare
brancz
reviewed
Jun 19, 2019
This commit enables metrics forwarding from one receive node to another. The receive nodes construct hashrings from the given sd-files and use these hashrings to select a node to which toforward a given time series. Time series are batched together to ensure that for any incoming write-request to a node, at most one outgoing write-request will be made every other node in the hashring.
brancz
approved these changes
Jun 20, 2019
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables metrics forwarding from one receive node to another.
The receive nodes construct hashrings from the given sd-files and
use these hashrings to select a node to which to forward a given time
series. Time series are batched together to ensure that for any incoming
write-request to a node, at most one outgoing write-request will be made
every other node in the hashring.
Changes
Verification
Added e2e tests for receive nodes in hashring
cc @brancz @bwplotka @metalmatze