website: add sponsor section on homepage #1062

adrien-f · 2019-04-19T13:27:37Z

Changes

website: add sponsor section

Verification

bwplotka · 2019-04-23T09:17:48Z

Awesome! How we should proceed here? Ask our users to provide logos to this PR? @adrien-f @domgreen

domgreen · 2019-04-23T10:01:53Z

I would personally merge this PR ... then ask people to open their own PRs against master. Means we dont end up stacking up too many and delaying this one

domgreen · 2019-04-23T10:02:44Z

Maybe add a small documentation saying How to add my logo as a Thanos user? Then out line in a number of bullets how to do it

adrien-f · 2019-04-23T14:31:36Z

Can you give me an Improbable-Eng logo to get started ?

bwplotka · 2019-04-23T15:57:32Z

@adrien-f sending you on DM

bwplotka · 2019-04-25T10:12:54Z

website/layouts/index.html

+    <div class="row">
+        <div class="col-12"><h3 class="text-center">Used by</h3></div>
+    </div>
+    <div class="row">


Wow you automated this <3

Can we add link to how-to-contribute-to-docs.md#Logos with message something like "Want to be added to list? Follow this"

How about
?

Yes! We can drop this when we have lot's of those ? And let's do it just very grey almost transparent?

bwplotka

Awesome job! LGTM, just can we link this md page somewhere in main page/ footer? Especially now temporarily when we will slowly add more & more logos.

bwplotka · 2019-04-25T14:10:27Z

website/layouts/index.html

-<div class="container-fluid">
+<div class="container py-5">
+    <div class="row">
+        <div class="col-12"><h3 class="text-center">Created by</h3></div>


Suggested change

<div class="col-12"><h3 class="text-center">Created by</h3></div>

<div class="col-12"><h3 class="text-center">Founded by</h3></div>

bwplotka · 2019-04-25T15:39:01Z

website/hugo.yaml

@@ -19,7 +19,7 @@ relativeURL: true
 contentDir: "docs-pre-processed"
 archetypeDir: "archetypes"
 layoutDir: "layouts"
-publishDi: "public"


publishDir?

Diff is weird here ? I've fixed the typo

just was curious why it is working on master then, that's fine

domgreen

Looks good, would just clarify images attributes 👍

docs/contributing/how-to-contribute-to-docs.md

domgreen · 2019-04-25T19:39:41Z

website/hugo.yaml

@@ -19,7 +19,7 @@ relativeURL: true
 contentDir: "docs-pre-processed"
 archetypeDir: "archetypes"
 layoutDir: "layouts"
-publishDi: "public"


publishDir?

domgreen · 2019-04-25T19:41:16Z

website/layouts/index.html

+        {{ range $sponsor := $.Site.Data.sponsors.sponsors }}
+        <div class="col-4 col-xl-2 py-3">
+            <div class="img-sponsor">
+                <a href="{{ $sponsor.url }}" rel="nofollow" target="_blank"><img src="{{ (printf "/logos/%s" $sponsor.logo) | relURL }}" alt="{{ $sponsor.name }}"></a>


what will happen if the logo is not present? Maybe have a default Thanos image to put there?

Added a check for the logo property !

bwplotka

Awesome! some nits and LGTM.

bwplotka · 2019-04-27T19:26:00Z

Makefile

@@ -34,7 +34,7 @@ GIT               ?= $(shell which git)
 BZR               ?= $(shell which bzr)

 WEB_DIR           ?= website
-WEBSITE_BASE_URL  ?= thanos.io


Please rebase ):

bwplotka · 2019-04-27T19:26:47Z

docs/contributing/how-to-contribute-to-docs.md

@@ -63,11 +63,26 @@ Keep `menu` the same as sub-directory the file is in. This will help to manage a

 Show new menu section in main page by changing `website/layouts/_default/baseof.html` file.

+## Logos


Isn't that too hidden? Just curious how we can make it more searchable. Maybe some hover over logos "Go there " etc?

Ok, let's ignore my comment. It's fine to this being there we can just redirect people if they will aks to be on page (:

docs/contributing/how-to-contribute-to-docs.md

bwplotka · 2019-04-27T19:28:21Z

website/layouts/index.html

+    <div class="row">
+        <div class="col-12"><h3 class="text-center">Used by</h3></div>
+    </div>
+    <div class="row">


Yes! We can drop this when we have lot's of those ? And let's do it just very grey almost transparent?

bwplotka · 2019-04-27T19:28:58Z

Awesome thanks for doing it. There is legit CI error though.

domgreen · 2019-05-02T12:43:52Z

personally would have the logo bigger under the Founded by section 👍 It is drowned by the size of the text above

bwplotka · 2019-05-02T12:55:59Z

And other logos as well bigger in same manner I think?

bwplotka · 2019-05-02T12:58:01Z

Let's all logos placeholder bit bigger, add some initial ones and announce rdy place for logos first then (: I want to have people pushing PRs, but we need to merge this first

* query: cleanup store statuses as they come and go (thanos-io#910) Signed-off-by: Adrien Fillon <adrien.fillon@cdiscount.com> * [docs] Example of using official prometheus helm chart to deploy server with sidecar (thanos-io#1003) * update documentation with an example of using official prometheus helm chart Signed-off-by: Ivan Kiselev <ivan@messagebird.com> * a little formatting to values Signed-off-by: Ivan Kiselev <ivan@messagebird.com> * satisfy PR comments Signed-off-by: Ivan Kiselev <ivan@messagebird.com> * Compact: group concurrency (thanos-io#1010) * compact: add concurrency to group compact * add flag to controll the number of goroutines to use when compacting group * update compact.md for group-compact-concurrency * fixed: miss wg.Add() * address CR * regenerate docs * use err group * fix typo in flag description * handle context * set up workers in main loop * move var initialisation * remove debug log * validate concurrency * move comment * warn -> error * remove extra newline * fix typo * dns: Added miekgdns resolver as a hidden option to query and ruler. (thanos-io#1016) Fixes: thanos-io#1015 Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * query: set default evaluation interval (thanos-io#1028) Subqueries allows request with no [specified resolution](https://prometheus.io/blog/2019/01/28/subquery-support/). Set it up and allow to configure default evaluation interval. * store+compactor: pre-compute index cache during compaction (thanos-io#986) Fixes first part of thanos-io#942 This changes allow to safe some startup & sync time in store gateway as it is no longer is needed to compute index-cache from block index on its own. For compatibility store GW still can do it, but it first checks bucket if there is index-cached uploaded already. In the same time, compactor precomputes the index cache file on every compaction. To allow quicker addition of index cache files we added `--index.generate-missing-cache-file` flag, that if enabled precompute missing files on compactor startup. Note that it will take time and it's only one-off step per bucket. Signed-off-by: Aleksei Semiglazov <xjewer@gmail.com> * Added website for Thanos' docs using Hugo. (thanos-io#807) Hosted in github pages. Signed-off-by: adrien-f <adrien.fillon@gmail.com> Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * gcs: Fixed scopes for inline ServiceAccount option. (thanos-io#1033) Without this that option was unusable. Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * Fixed root docs and liche is now checking root dir as well. (thanos-io#1040) Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * storage docs: add detail about GCS policies and testing (thanos-io#1037) * add more details about GCS policies and testing * remove fixed names from exec command * Prometheus library updated to v2.8.1 (thanos-io#1009) * compact: group concurrency improvements (thanos-io#1029) * group concurrency improvements * remove unnecessary error check * add to wg in main goroutine * receive: Add block shipping (thanos-io#1011) * receive: Add retention flag for local tsdb storage (thanos-io#1046) * querier: Add /api/v1/labels support (thanos-io#905) * Feature: add /api/v1/labels support Signed-off-by: jojohappy <sarahdj0917@gmail.com> * Disabled gossip by default, marked all flags as deprecated. (thanos-io#1055) + changed small label. Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * ruler: Fixed Chunk going out or Max Uint16. (thanos-io#1041) Fixes thanos-io#1038 Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * store: azure: allow passing an endpoint parameter for specific regions (thanos-io#980) Fix thanos-io#968 Signed-off-by: Adrien Fillon <adrien.fillon@cdiscount.com> * feature: support POST method for series endpoint (thanos-io#1021) Signed-off-by: Joseph Lee <joseph.t.lee@outlook.com> * bucket verify: repair out of order labels (thanos-io#964) * bucket verify: repair out of order labels * verify repair: correctly order series in the index on rewrite When we have label sets that are not in the correct order, fixing that changes the order of the series in the index. So the index must be rewritten in that new order. This makes this repair tool take up a bunch more memory, but produces blocks that verify correctly. * Fix the TSDB block safe-delete function The directory name must be the block ID name exactly to verify. A temp directory or random name will not work here. * verify repair: fix duplicate chunk detection Pointer/reference logic error was eliminating all chunks for a series in a given TSDB block that wasn't the first chunk. Chunks are now referenced correctly via pointers. * PR feedback: use errors.Errorf() instead of fmt.Errorf() * Use errors.New() Some linters catch errors.Errorf() as its not really part of the errors package. * Liberally comment this for loop We're comparing items by pointers, using Go's range variables is misleading here and we need not fall into the same trap. * Take advantage of sort.Interface This prevents us from having to re-implement label sorting. * PR Feedback: Comments are full sentences. * Cut release 0.4.0-rc.0 (thanos-io#1017) * Cut release 0.4.0-rc.0 🎉 🎉 NOTE: This is last release that has gossip. Signed-off-by: Bartek Plotka <bwplotka@gmail.com> Co-Authored-By: povilasv <p.versockas@gmail.com> * Fixed crossbuild. Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * ci: Env fixes. (thanos-io#1058) Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * Removed bzr requirement for make crossbuild. Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * Bump github.com/hashicorp/golang-lru from 0.5.0 to 0.5.1 (thanos-io#1051) Bumps [github.com/hashicorp/golang-lru](https://github.com/hashicorp/golang-lru) from 0.5.0 to 0.5.1. - [Release notes](https://github.com/hashicorp/golang-lru/releases) - [Commits](hashicorp/golang-lru@v0.5.0...v0.5.1) Signed-off-by: dependabot[bot] <support@dependabot.com> * Initialze and correctly register all index cache metrics. (thanos-io#1069) * store/cache: add more tests (thanos-io#1071) * Fixed Downsampling process; Fixed `runutil.CloseAndCaptureErr` (thanos-io#1070) * runutil. Simplified CloseWithErrCapture. Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * Fixed Downsampling process; Fixed runutil.CloseAndCaptureErr Fixes thanos-io#1065 Root cause: * runutil defered capture error function was not passing error properly so unit tests were passing, event though there was bug * streamed block write index cache requires index file which was not closed (saved) properly yet. Closers need to be closed to perform this. Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * objstore: Expose S3 region attribute (thanos-io#1060) Minio is able to autodetect the region for cloud providers like AWS but the logic fails with Scaleway Object Storage solution. Related issue on Minio: minio/mc#2570 * Fixed fetching go-bindata failed (thanos-io#1074) * Fixed bug: - fetching go-bindata failed. - change the repo of go-bindata to github.com/go-bindata/go-bindata, because old repo has been archived. - pin the go-bindata as v3.3.1. Signed-off-by: jojohappy <sarahdj0917@gmail.com> * Add CHANGELOG Signed-off-by: jojohappy <sarahdj0917@gmail.com> * Remove CHANGELOG Signed-off-by: jojohappy <sarahdj0917@gmail.com> * add compare flags func to compare flags between prometheus and sidecar (thanos-io#838) Original message: * update documentation for a max/min block duration add compare flags func to compare flags between prom and sidecar * fix some nits Functional change: now we check the configured flags (if possible) and error out if MinTime != MaxTime. We need to check this always since if that is not true then we will get overlapping blocks. Additionally, an error message is printed out if it is not equal to 2h (the recommended value). * Ensured index cache is best effort, refactored tests, validated edge cases. (thanos-io#1073) Fixes thanos-io#651 Current size also includes slice header. Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * website: Moved to netlify. (thanos-io#1078) Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * website: Fixing netlify. (thanos-io#1080) Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * website: Added "founded by" footer. (thanos-io#1081) Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * store/proxy: properly check if context has ended (thanos-io#1082) How the code was before it could happen that we might receive some series from the stream however by the time we'd send them back to the reader, it would not read it anymore since the deadline would have been exceeded. Properly use a `select` here to get out of the goroutine if the deadline has been exceeded. Might potentially fix a problem where we see one goroutine hanging constantly (and thus blocking from work being done): ``` goroutine profile: total 126 25 @ 0x42f62f 0x40502b 0x405001 0x404de5 0xe7435b 0x45cc41 0xe7435a github.com/improbable-eng/thanos/pkg/store.startStreamSeriesSet.func1+0x18a /go/src/github.com/improbable-eng/thanos/pkg/store/proxy.go:318 ``` * Cut release v0.4.0-rc.1 (thanos-io#1088) Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * website: Removed ghpages handling; fixed docs; and status badge. (thanos-io#1084) Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * Fix readme (thanos-io#1090) * store: Compose indexCache properly allowing injection for testing purposes. (thanos-io#1098) Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * website: add sponsor section on homepage (thanos-io#1062) * website: Adjusted logos sizing and responsiveness. (thanos-io#1105) Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * Add Monzo to "Used by" section 🎉 (thanos-io#1106) * Compactor: remove malformed blocks after delay (thanos-io#1053) * compactor removes malformed blocks after delay * compactor removes malformed blocks after delay * include missing file * reuse existing freshness check * fix comment * remove unused var * fix comment * syncDelay -> consistencyDelay * fix comment * update flag description * address cr * fix dupliacte error handling * minimum value for --consistency-delay * update * docs * add test case * move test to inmem bucket * Add Utility Warehouse to "used by" section (thanos-io#1108) * Add Utility Warehouse logo * Make logo smaller * website: add Adform as users (thanos-io#1109) We use Thanos extensively as well so I have added Adform. * Cut release v0.4.0 (thanos-io#1107) Signed-off-by: Bartek Plotka <bwplotka@gmail.com>

bwplotka self-requested a review April 23, 2019 18:17

adrien-f force-pushed the feature/website-sponsors branch 2 times, most recently from 8e9639a to 63bf5d6 Compare April 25, 2019 10:01

bwplotka reviewed Apr 25, 2019

View reviewed changes

bwplotka approved these changes Apr 25, 2019

View reviewed changes

povilasv approved these changes Apr 25, 2019

View reviewed changes

bwplotka reviewed Apr 25, 2019

View reviewed changes

domgreen reviewed Apr 25, 2019

View reviewed changes

adrien-f force-pushed the feature/website-sponsors branch 2 times, most recently from c1c8c2f to ebd10bc Compare April 26, 2019 08:16

bwplotka approved these changes Apr 27, 2019

View reviewed changes

adrien-f force-pushed the feature/website-sponsors branch 2 times, most recently from a0e037e to c28c7d7 Compare May 2, 2019 09:17

website: add sponsor section on homepage

77a9dde

adrien-f force-pushed the feature/website-sponsors branch from c28c7d7 to 77a9dde Compare May 2, 2019 09:23

bwplotka merged commit f16b88c into thanos-io:master May 2, 2019

bwplotka deleted the feature/website-sponsors branch May 2, 2019 16:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

website: add sponsor section on homepage #1062

website: add sponsor section on homepage #1062

adrien-f commented Apr 19, 2019

bwplotka commented Apr 23, 2019

domgreen commented Apr 23, 2019

domgreen commented Apr 23, 2019

adrien-f commented Apr 23, 2019

bwplotka commented Apr 23, 2019

bwplotka Apr 25, 2019

adrien-f Apr 26, 2019

bwplotka Apr 27, 2019

bwplotka left a comment

bwplotka Apr 25, 2019

bwplotka Apr 25, 2019

domgreen Apr 25, 2019

adrien-f Apr 26, 2019

bwplotka Apr 27, 2019

domgreen left a comment

domgreen Apr 25, 2019

domgreen Apr 25, 2019

adrien-f Apr 26, 2019

bwplotka left a comment

bwplotka Apr 27, 2019

bwplotka Apr 27, 2019

bwplotka Apr 30, 2019

bwplotka Apr 27, 2019

bwplotka commented Apr 27, 2019

domgreen commented May 2, 2019

bwplotka commented May 2, 2019

bwplotka commented May 2, 2019

	<div class="col-12"><h3 class="text-center">Created by</h3></div>
	<div class="col-12"><h3 class="text-center">Founded by</h3></div>

		@@ -63,11 +63,26 @@ Keep `menu` the same as sub-directory the file is in. This will help to manage a

		Show new menu section in main page by changing `website/layouts/_default/baseof.html` file.

		## Logos

website: add sponsor section on homepage #1062

website: add sponsor section on homepage #1062

Conversation

adrien-f commented Apr 19, 2019

Changes

Verification

bwplotka commented Apr 23, 2019

domgreen commented Apr 23, 2019

domgreen commented Apr 23, 2019

adrien-f commented Apr 23, 2019

bwplotka commented Apr 23, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bwplotka left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

domgreen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bwplotka left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bwplotka commented Apr 27, 2019

domgreen commented May 2, 2019

bwplotka commented May 2, 2019

bwplotka commented May 2, 2019