Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitPod script or remove it from contributing doc #6905

Closed
yeya24 opened this issue Nov 19, 2023 · 1 comment
Closed

Update GitPod script or remove it from contributing doc #6905

yeya24 opened this issue Nov 19, 2023 · 1 comment

Comments

@yeya24
Copy link
Contributor

yeya24 commented Nov 19, 2023

Is your proposal related to a problem?

* Spin up a prebuilt dev environment using Gitpod.io [![Gitpod Ready-to-Code](https://img.shields.io/badge/Gitpod-ready--to--code-blue?logo=gitpod)](https://gitpod.io/#https://github.com/thanos-io/thanos)

We mentioned to spin up a GitPod environment in our contributing doc. However, the gitpod configuration was added 3 years ago and nobody maintains it.

https://cloud-native.slack.com/archives/CL25937SP/p1700335519924849 It caused some confusion for contributors when trying GitPod.

Describe the solution you'd like

There is GH codespace feature now and we have a better maintained devcontainer configuration https://github.com/thanos-io/thanos/tree/main/.devcontainer.

If we still want to maintain GitPod config, we should update GitPod config to be the same as GH codespace. Otherwise, we can remove GitPod config and stop mentioning it in our doc.

Describe alternatives you've considered

(Write your answer here.)

Additional context

(Write your answer here.)

@yeya24
Copy link
Contributor Author

yeya24 commented Nov 21, 2023

Resolved by #6907

@yeya24 yeya24 closed this as completed Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant