Feature Request: Replicate can copy individual blocks

[maulikjs]

So today we faced an issue where a few blocks were not copied to our destination bucket and I had to manually copy them over, I am still trying to figure out what went wrong but it would be a nice feature to have if the replicate can copy individual blocks over.

One another feature that would be really useful is to verify if all the blocks have been copied over between 2 buckets and maybe give a report for those which might have been missed.

[yeya24]

I think the first feature is nice and we can support it easily.

[bwplotka]

Well, replicate does exactly this. It compares those two buckets. So even if we had additional logic, same bug might happened (: Let's dive into why it was missed. BTW what version you are using? Are you on Thanos tools replicate now?

…

On Wed, 3 Jun 2020 at 22:16, Ben Ye ***@***.***> wrote: I think the first feature is nice and we can support it easily. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2713 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVA3O2YWPLPEKVEHPQUONDRU24SNANCNFSM4NSANHWA> .

[stale]

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[stale]

Closing for now as promised, let us know if you need this to be reopened! 🤗

[bwplotka]

Lets get back on this. Help wanted!

[yeya24]

I can take this one if no one is on it. This feature can be implemented by adding specified blocks ID to blockFilter https://github.com/thanos-io/thanos/blob/master/pkg/replicate/scheme.go#L30.

[stale]

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[yeya24]

Still on it. Blocked by #2906

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[kakkoyun]

@yeya24 Can we do anything to unblock #2906?

[yeya24]

@kakkoyun Please help review #2906

[yeya24]

Will take this.