fix review comments

Signed-off-by: Ben Ye <yb532204897@gmail.com>
thanos-io · Nov 21, 2020 · e8b3656 · e8b3656
1 parent 0064d3a
commit e8b3656
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 36 deletions.
diff --git a/cmd/thanos/tools_bucket.go b/cmd/thanos/tools_bucket.go
@@ -454,11 +454,11 @@ func registerBucketReplicate(app extkingpin.AppClause, objStoreConfig *extflag.P
 
 		blockIDs := make([]ulid.ULID, 0, len(*ids))
 		for _, id := range *ids {
-			if bid, err := ulid.Parse(id); err != nil {
+			bid, err := ulid.Parse(id)
+			if err != nil {
 				return errors.Wrap(err, "invalid ULID found in --id flag")
-			} else {
-				blockIDs = append(blockIDs, bid)
 			}
+			blockIDs = append(blockIDs, bid)
 		}
 
 		return replicate.RunReplicate(

diff --git a/pkg/compactv2/modifiers_test.go b/pkg/compactv2/modifiers_test.go