Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
Signed-off-by: Aditi Ahuja <ahuja.aditi@gmail.com>
  • Loading branch information
metonymic-smokey committed Jun 16, 2022
1 parent bb80c4a commit 1a8134b
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 14 deletions.
12 changes: 6 additions & 6 deletions pkg/tracing/client/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@ import (
type TracingProvider string

const (
Stackdriver TracingProvider = "STACKDRIVER"
GoogleCloud TracingProvider = "GOOGLE_CLOUD"
Jaeger TracingProvider = "JAEGER"
ElasticAPM TracingProvider = "ELASTIC_APM"
Lightstep TracingProvider = "LIGHTSTEP"
name = "thanos"
Stackdriver TracingProvider = "STACKDRIVER"
GoogleCloud TracingProvider = "GOOGLE_CLOUD"
Jaeger TracingProvider = "JAEGER"
ElasticAPM TracingProvider = "ELASTIC_APM"
Lightstep TracingProvider = "LIGHTSTEP"
OpenTelemetryProtocol TracingProvider = "OTLP"
)

type TracingConfig struct {
Expand Down
7 changes: 0 additions & 7 deletions pkg/tracing/jaeger/jaeger.go
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,6 @@ func NewTracer(ctx context.Context, logger log.Logger, metrics *prometheus.Regis
return nil, nil, err
}

level.Info(logger).Log("msg", "getting tracing config", cfg)
cfg.Headers = &jaeger.HeadersConfig{
JaegerDebugHeader: strings.ToLower(tracing.ForceTracingBaggageKey),
}
Expand All @@ -165,12 +164,6 @@ func NewTracer(ctx context.Context, logger log.Logger, metrics *prometheus.Regis
return nil, nil, err
}

exp, err := otel_jaeger.New(otel_jaeger.WithCollectorEndpoint())
if err != nil {
return nil, nil, err
}
_ = exp

t := &Tracer{
jaegerTracer,
}
Expand Down
4 changes: 3 additions & 1 deletion test/e2e/tracing_test.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// Copyright (c) The Thanos Authors.
// Licensed under the Apache License 2.0.
package e2e_test

import (
Expand All @@ -13,7 +15,7 @@ import (
"gopkg.in/yaml.v2"
)

// test to check if the trace provider works as expected
// Test to check if the trace provider works as expected.
func TestJaegerTracing(t *testing.T) {
env, err := e2e.NewDockerEnvironment("e2e-tracing-test")
testutil.Ok(t, err)
Expand Down

0 comments on commit 1a8134b

Please sign in to comment.