Fixes bedsheets laid incorrectly onto beds

[tralezab]

About The Pull Request

Fixes #85571

Why It's Good For The Game

Just a push in the direction of a de-jank'd wallening

Changelog

🆑
fix: bedsheets are laid on beds properly now
/:cl:

[00-Steven]

Should probably use the defines/macros, but broadly this feels a bit awkward on an item? Like what about placing it anywhere else like on tables or racks or somesuch?
Doesn't it spawning on a bed also already adjust the pixel_y by DEPTH_OFFSET to fit on the bed?

tgstation/code/game/objects/structures/bedsheet_bin.dm

Lines 47 to 50 in 1202be8

	for(var/stuff as anything in loc)
	if(istype(stuff, /obj/structure/bed))
	pixel_y = DEPTH_OFFSET
	return

[tralezab]

Should probably use the defines/macros

Realized that, added!

but broadly this feels a bit awkward on an item? Like what about placing it anywhere else like on tables or somesuch?

Maybe? Also thank you for finding that line. Okay, let me try a potential solution without shifting bedsheets upwards, it might not be necessary

[00-Steven]

I thiiiiiiink the code for putting bedsheets on beds and having them be offset might be this, having looked into it a bit more:

tgstation/code/game/objects/structures/bedsheet_bin.dm

Line 41 in 6c9cfa1

AddElement(/datum/element/bed_tuckable, mapload, 0, 0, 0)

tgstation/code/datums/elements/bed_tucking.dm

Lines 14 to 20 in 6c9cfa1

	/datum/element/bed_tuckable/Attach(obj/target, mapload = FALSE, x = 0, y = 0, rotation = 0)
	. = ..()
	if(!isitem(target))
	return ELEMENT_INCOMPATIBLE
	x_offset = x
	y_offset = y

tgstation/code/datums/elements/bed_tucking.dm

Lines 55 to 58 in 6c9cfa1

	/datum/element/bed_tuckable/proc/tuck(obj/item/tucked, obj/structure/bed/target_bed)
	tucked.dir = target_bed.dir
	tucked.pixel_x = target_bed.dir & EAST ? -x_offset : x_offset
	tucked.pixel_y = y_offset

Which I believe is also used by other items you can put on beds.

So might be as simple as adding the right define to the y_offset for adding the element.

[tralezab]

You were right, I didn't need it after all, I can just fix the elements. Each one getting +12 and we're good. Thanks

[00-Steven]

o7