Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More GraphQL Work #1936

Open
wants to merge 109 commits into
base: dev
Choose a base branch
from
Open

More GraphQL Work #1936

wants to merge 109 commits into from

Conversation

Cyberboss
Copy link
Member

@Cyberboss Cyberboss commented Sep 22, 2024

Completed user manager

#1077

🆑
Fixed some oddities in the authentication/authorization pipeline.
/🆑

🆑 HTTP API
Reserved error code 109 for a future change.
/🆑

🆑 Nuget: API
BREAKING: Removed IEquatable implementations for SwarmServers.
BREAKING: RightsHelper.RoleNames now returns an IEnumerable<string> instead of a comma separated string.
BREAKING: Non-functionally rearranged some class structures again.
/🆑

🆑 Nuget: Client
BREAKING: Updated Tgstation.Server.Api to v16.0.0.
/:cl:

- Introduce the concept of `IAuthority`s to handle business logic for both REST and GraphQL.
- Add new authorize attributes so roles can be defined on `IAuthority`s and inherited on REST/GraphQL API surface.
- Implement `ILoginAuthority`, converting REST methods to use it.
- Partially implement `IUserAuthority`, converting REST methods to use it.
- Setup `ErrorMessageResponse` filtering for GraphQL fields.
- Setup query structure for the potential for `RemoteGateway`s.
  - Add new `ErrorCode` indicating they are not implemented.
- Rename `ServerInformationBase` to `GatewayInformationBase`.
- Fix `TgsRestAuthorizeAttribute` lacking an `IAuthorizationFilter`.
…that wasn't present previously. Validate nodes can be resolved
tgstation-server-ci[bot]
tgstation-server-ci bot previously approved these changes Sep 24, 2024
tgstation-server-ci[bot]
tgstation-server-ci bot previously approved these changes Sep 24, 2024
tgstation-server-ci[bot]
tgstation-server-ci bot previously approved these changes Sep 24, 2024
tgstation-server-ci[bot]
tgstation-server-ci bot previously approved these changes Sep 24, 2024
tgstation-server-ci[bot]
tgstation-server-ci bot previously approved these changes Sep 24, 2024
tgstation-server-ci[bot]
tgstation-server-ci bot previously approved these changes Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client Issue with the .NET client library Feature New functionality Fix Fixes incorrect functionality HTTP API The JSON Web API that controls the server Refactor Refactor functionality for future improvements size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant