fix http requests not properly setting the status code #231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the reqwest -> ureq port had a slight whoopsie, non-2xx status code would always error (not setting the
status_code
) field due to how ureq worked, as a non-2xx status code would return anErr(ureq::Error::Status(status_code, response))
instead of anOk(response)
this fixes that, so that non-2xx status codes will still return the body and such, including setting the status code.