-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAS Ammo updates and cleanup #5604
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgstation-server
added
Code Improvement
Changes for adhering to code standards and codebase maintainability.
Feature
New interesting mechanics with new interesting bugs
Fix
Fixes an issue with the game.
Refactor
Improves underlying code to make systems more modular and functional.
Sound
Sound change.
Sprites
Changes to .dmi file.
UI
We make things worse, but rounder
labels
Dec 30, 2020
Hughgent
reviewed
Dec 30, 2020
@@ -300,15 +319,14 @@ | |||
ammo_count = 6 | |||
max_ammo_count = 6 | |||
ammo_name = "minirocket" | |||
travelling_time = 80 //faster than 30mm cannon, slower than real rockets | |||
travelling_time = 7 SECONDS //faster than 30mm cannon, slower than real rockets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
balance change
Based |
ghost
mentioned this pull request
Jan 2, 2021
TiviPlus
added
the
Test Merge Candidate
This PR has been reviewed and is ready for testing, unless something changes.
label
Jan 2, 2021
github-actions
bot
added
the
Merge Conflict
Pull request is in a conflicted state with base branch.
label
Jan 3, 2021
tgstation-server
removed
Merge Conflict
Pull request is in a conflicted state with base branch.
Test Merge Candidate
This PR has been reviewed and is ready for testing, unless something changes.
labels
Jan 5, 2021
@Hughgent No bugs and balanced, good for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Code Improvement
Changes for adhering to code standards and codebase maintainability.
Feature
New interesting mechanics with new interesting bugs
Fix
Fixes an issue with the game.
Refactor
Improves underlying code to make systems more modular and functional.
Sound
Sound change.
Sprites
Changes to .dmi file.
UI
We make things worse, but rounder
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Title and Changelog
Why It's Good For The Game
Change.Me.-.Debugdalus.2020-12-30.20-52-48.mp4
Change.Me.-.Debugdalus.2020-12-30.21-27-15.mp4
(Latter video isnt the final version)
Changelog
🆑
add: Reworked GAU to be a proper minigun, cool effects included
add: Reworked lazer to fire a beam of fire
add: New Smoke mini rockets
add: Napalm rockets now release WP
fix: fixed bad OOP causing all missiles to create a random fire tile
imageadd: New CAS impact icon by Kuro
code: Replaced the deprecated reverse_direction proc
code: shuffled defenitions to the correct files
refactor: Refactored GAUs, documented some variables and added support for CAS directional attacks
/:cl: