Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAS Ammo updates and cleanup #5604

Merged
merged 4 commits into from
Jan 5, 2021
Merged

Conversation

TiviPlus
Copy link
Member

@TiviPlus TiviPlus commented Dec 30, 2020

About The Pull Request

Title and Changelog

Why It's Good For The Game

Change.Me.-.Debugdalus.2020-12-30.20-52-48.mp4
Change.Me.-.Debugdalus.2020-12-30.21-27-15.mp4

(Latter video isnt the final version)

Changelog

🆑
add: Reworked GAU to be a proper minigun, cool effects included
add: Reworked lazer to fire a beam of fire
add: New Smoke mini rockets
add: Napalm rockets now release WP
fix: fixed bad OOP causing all missiles to create a random fire tile
imageadd: New CAS impact icon by Kuro
code: Replaced the deprecated reverse_direction proc
code: shuffled defenitions to the correct files
refactor: Refactored GAUs, documented some variables and added support for CAS directional attacks
/:cl:

@tgstation-server tgstation-server added Code Improvement Changes for adhering to code standards and codebase maintainability. Feature New interesting mechanics with new interesting bugs Fix Fixes an issue with the game. Refactor Improves underlying code to make systems more modular and functional. Sound Sound change. Sprites Changes to .dmi file. UI We make things worse, but rounder labels Dec 30, 2020
@@ -300,15 +319,14 @@
ammo_count = 6
max_ammo_count = 6
ammo_name = "minirocket"
travelling_time = 80 //faster than 30mm cannon, slower than real rockets
travelling_time = 7 SECONDS //faster than 30mm cannon, slower than real rockets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

balance change

@Al-1ce
Copy link
Contributor

Al-1ce commented Jan 1, 2021

Based

@TiviPlus TiviPlus added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Jan 2, 2021
@github-actions github-actions bot added the Merge Conflict Pull request is in a conflicted state with base branch. label Jan 3, 2021
@tgstation-server tgstation-server removed Merge Conflict Pull request is in a conflicted state with base branch. Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. labels Jan 5, 2021
@TiviPlus
Copy link
Member Author

TiviPlus commented Jan 5, 2021

@Hughgent No bugs and balanced, good for merge

@Hughgent Hughgent merged commit 78d38cf into tgstation:master Jan 5, 2021
@TiviPlus TiviPlus deleted the casupdates branch January 5, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Changes for adhering to code standards and codebase maintainability. Feature New interesting mechanics with new interesting bugs Fix Fixes an issue with the game. Refactor Improves underlying code to make systems more modular and functional. Sound Sound change. Sprites Changes to .dmi file. UI We make things worse, but rounder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants