Breakout Room 9: Update main.py #11
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,23 @@ | ||
| #Mad Libs Generator Project | ||
| //Loop back to this point once code finishes | ||
| loop = 1 | ||
|
Collaborator
There was a problem hiding this comment. The variable name loop is confusing, try using counter to make this code more readable. |
||
| while (loop < 9): | ||
|
Collaborator
There was a problem hiding this comment. Consider revisiting the requirements in regards to how many times this loop is ran. This is only being ran 8 times. We suggest starting with 0 and change it to "<=" instead of "<". Please consider the loop variable, is it functioning as intended?
Collaborator
There was a problem hiding this comment. Why is this in parenthesis? |
||
| // All the questions that the program asks the user | ||
| noun = input("Choose a noun: ") | ||
| plural_noun = input("Choose a plural noun: ") | ||
| second_noun = input("Choose a noun: ") | ||
| place = input("Name a place: ") | ||
| adjective = input("Choose an adjective (Describing word): ") | ||
| third_noun = input("Choose a noun: ") | ||
|
Comment on lines
+2
to
+11
Collaborator
There was a problem hiding this comment. Consider placing a guard clause for invalid input and error handling.
Comment on lines
+6
to
+11
Collaborator
There was a problem hiding this comment. Could we place these into a dictionary and iterate through in order to create the string? |
||
| // Displays the story based on the users input | ||
|
Collaborator
There was a problem hiding this comment. One feature could be added here to display the line up to the inputted word for the user to see and build on the display after every input. |
||
| print ("------------------------------------------") | ||
| print ("Be kind to your",noun,"- footed", plural_noun) | ||
| print ("For a duck may be somebody's", seond_noun,",") | ||
|
Collaborator
There was a problem hiding this comment. There is a typo for the second noun variable name. |
||
| print ("Be kind to your",plural_noun,"in",place) | ||
| print ("Where the weather is always",adjective,".") | ||
| print () | ||
| print ("You may think that is this the",third_noun,",") | ||
| print ("Well it is.") | ||
| print ("------------------------------------------") | ||
|
Collaborator
There was a problem hiding this comment. It may be good to add a feature to allow the user to stop playing and to count how many times they have played out of the 10 trials. |
||
| // Loop back to "loop = 1" | ||
|
Comment on lines
+12
to
+22
Collaborator
There was a problem hiding this comment. Please consider reviewing and correcting formatting using an f-string. |
||
| loop = loop + 1 | ||
|
Comment on lines
1
to
+23
Collaborator
There was a problem hiding this comment. Syntax for comments is incorrect. Comments need to start with #.
Comment on lines
1
to
+23
Collaborator
There was a problem hiding this comment. By using functions we can separate the input and display. Please review the single responsibility principal. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try adding testing for edge cases