Wrapping client interface #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot/cherry-pick-2343-to-release-0.15 [release-0.15] ✨Fix logs in unstructured client
* Fix unspecified KindsFor version * Dont allocate empty list Co-authored-by: Alvaro Aleman <alvaroaleman@users.noreply.github.com> * Test all four relevant interface methods, and do not assert count * Attempt to format correctly in web editor * Remove request count asserts * Remove non-version item asserts --------- Co-authored-by: Amund Tenstad <github@amund.io> Co-authored-by: Alvaro Aleman <alvaroaleman@users.noreply.github.com>
…onflicts The fake client of subresource is unable to correctly handle the case of resource version conflict when updating. The phenomenon is that it did not return a 409 status error. Signed-off-by: iiiceoo <iiiceoo@foxmail.com>
…ot/cherry-pick-2365-to-release-0.15 [release-0.15] 🐛 fakeClient.Status().Update(...) cannot recognize resource version conflicts
…ernetes-sigs#2373) * fix: hasLabels and matchingLabels step on each other * remove testcase with invalid input --------- Co-authored-by: Shanshan.Ying <shanshan.ying@apecloud.com>
This broke when we added the HTTP client, because the user-agent gets set by a roundtripper that is constructed within `rest.HTTPClientFor`. As a result, we have to default it before we do that. Currently, it ends up being defaulted to `Go-http-client` which is not very useful.
[release-0.15] 🐛 Fix Defaulting of the User Agent
…-panic-backport-to-v0.15 [release-0.15] 🐛 Fix TerminalError(nil).Error() panic
As the function is currently written without a return, for an unstructured object which is successfully unmashalled, it will fall through to the subsequent lines and fail to decode properly. Add return statement to successful unstructured decode. Signed-off-by: Leah Leshchinsky <lleshchi@redhat.com>
…ot/cherry-pick-2433-to-release-0.15 [release-0.15] 🐛 Add missing return statement in the webhook admissions func
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.