Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aria2 #211

Merged
merged 1 commit into from
Mar 4, 2023
Merged

feat: add aria2 #211

merged 1 commit into from
Mar 4, 2023

Conversation

oElberte
Copy link
Contributor

No description provided.

@SanujaNS
Copy link
Collaborator

SanujaNS commented Mar 1, 2023

This is interesting. Is this working?

@oElberte
Copy link
Contributor Author

oElberte commented Mar 1, 2023

This is interesting. Is this working?

Yes, I just can’t guarantee with docker and kubernetes, but I’ve added aria2 in the apk.txt so they can use. I went from 500KB/s to 10MB/s.
But even if doesn’t work, yt-dlp just ignores aria2 and downloads normally.

@BennyThink BennyThink added the enhancement New feature or request label Mar 2, 2023
@BennyThink BennyThink self-requested a review March 2, 2023 17:52
BennyThink added a commit that referenced this pull request Mar 2, 2023
Copy link
Member

@BennyThink BennyThink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a know issue from yt-dlp yt-dlp/yt-dlp#6369

I tried daily build, and it's back to normal. Can you add an environment to control this behavior, i.e.

if os.getenv("ENABLE_ARIA2"):
    ydl_opts.update(
        external_downloader="aria2c",
        external_downloader_args=[....]
    )

BennyThink added a commit that referenced this pull request Mar 2, 2023
@BennyThink BennyThink merged commit 0f3dd86 into tgbot-collection:master Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants