Skip to content

fix the username for group routing test case #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

eesaanatluri
Copy link
Contributor

Hi @tg123, quick fix for using the correct username in group-routing test case on L#511.

Could you please merge this ?

@tg123
Copy link
Owner

tg123 commented Apr 8, 2025

lol how old pr test passed?

@tg123 tg123 merged commit 9564261 into tg123:master Apr 8, 2025
2 checks passed
@eesaanatluri
Copy link
Contributor Author

It was handled by the catch_all rule .*. Since publickey is in the authorized_keys file and system user is not checked in piper when it hits the catch_all rule it passed the test for group_routing_key at catch_all rule.

@tg123
Copy link
Owner

tg123 commented Apr 8, 2025

then i believe need to fix the testcase
or nothing get covered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants