Update to Phoenix LiveView 1.0 #128
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the application to work with Phoenix LiveView 1.0, including several API changes and syntax updates:
1. Dependency Updates:
- Changed phoenix_live_view from ">=0.20.0 and <0.21.0" to "~> 1.0.0"
- Updated floki to "~> 0.36.0"
- Multiple dependency version updates in mix.lock
2. API Changes:
- Updated Gettext usage from `use Gettext` to `use Gettext.Backend`
- Changed `Tuple.append` to `Tuple.insert_at` with explicit size parameter
- Replaced all instances of `push_redirect` with `push_navigate` to align with LiveView 1.0 API
3. Template Syntax Changes:
- Updated template interpolation syntax throughout components
- Changed from ERB-style `<%= ... %>` to the more concise `{...}` format
- Updated in container, nav, and resource components
tfwright
reviewed
Apr 29, 2025
There was a problem hiding this comment.
Looks good! There are a couple of changes that don't look necessarily related to the LV upgrade. If so, I would prefer to break them out into a separate PR (or at least separate commits in this PR). If you do that I will test it out a bit more and then merge.
| @@ -1,5 +1,5 @@ | |||
| defmodule Demo.Gettext do | |||
| use Gettext, otp_app: :demo, priv: "dev/gettext" | |||
There was a problem hiding this comment.
The gettext dep is not changed in this PR. Are you sure this warning is new to LV 1.0?
| @@ -111,7 +111,7 @@ defmodule LiveAdmin do | |||
| with result = {_, m, f, _} <- | |||
| extract_function_from_config(resource, session, function_type, function), | |||
| docs when is_map(docs) <- extract_function_docs(m, f) do | |||
| Tuple.append(result, docs) | |||
There was a problem hiding this comment.
This must be related to Elixir rather than Phoenix version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade LiveView to 1.0
This PR updates LiveAdmin to work with Phoenix LiveView 1.0.
What changed:
phoenix_live_view,floki, and related packages).Gettextusage.<%= ... %>to{...}.Why:
Notes: