ViewSet inheritance issue

[konkab]

I have two ViewSets subclassed from another ViewSet. Subclasses are decorated with @extend_view_schema with identical method names, but different extend_schema values (different tag names).

The subclasses are located in different apps.

appointments/views.py:

class AppointmentViewSet(viewsets.GenericViewSet):

doctors/views.py:

...
@extend_schema_view(
    notes=extend_schema(tags=["Doctor Appointments"], summary="Get appointment notes"),
    ...
)
class AppointmentViewSet(AppointmentViewSet): # superclass imported from appointments/views.py
...

patients/views.py:

...
@extend_schema_view(
    notes=extend_schema(tags=["Patient Appointments"], summary="Get appointment notes"),
    ...
)
class AppointmentViewSet(AppointmentViewSet): # superclass imported from appointments/views.py
...

One ViewSet is registered in doctors.urls, the other in patient.urls.

"app".urls:

urlpatterns = [
    path('api/doctors/', include('doctors.urls')),
    path('api/patients/', include('patients.urls')),
]

The issue is that "doctors" tags get overriden by "patients" tags. Basically all parameters get overriden by last added path.

It seems like the extend_schema decorators stick to superclass only.

[tfranzel]

hi @konkab, yes this is a bug in the extend_schema_view mechanics, which are more complicated than they look.

the tests only covered the base class case like:

@extend_schema_view(list=..., ...)
class XViewset(mixins.ListModelMixin, mixins.RetrieveModelMixin, viewsets.GenericViewSet)::
    ....

i'll have to investigate how to fix this.

[elvirTatarevic]

@tfranzel Any updates on this issue? I am also trying to extend a parent class and a child class, but only the parent extension is applied to both.

[tfranzel]

hi @elvirTatarevic! i have not gotten around investigating this further. its a tricky issue. i'll have to deal with 3-4 other issues first. after that i will have a look at it again.

[elvirTatarevic]

@tfranzel No problem man. We all appreciate everything that is being done. For now, a base class kind of seems to do the trick.

[filipemir]

Just adding my vote for a fix here. Ran into this today and thought I was losing what little sanity I can claim

[tfranzel]

@filipemir please reclaim your valuable sanity by checking out the current master branch.

@elvirTatarevic @konkab, would be great if you do that too.

This bug was actually a rather small oversight, but I was unable to see the forest for the trees there. Many thanks to @ngnpope. In #554, we addressed at least 3 different issues regarding isolation/inheritance. I'm not aware of any remaining issues in that regard, which is why I ask you kindly to test those fixes.

let me know if anything is still not behaving as expected!

[filipemir]

Hey @tfranzel. Works for me! With the latest version I was able to erase a bunch of duplicated annotations all over our code which was just the sort of satisfying work I needed at this stage in the day. Thank you!