Skip to content

Adding aarch64-linux architecture support #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NicolasGuilloux
Copy link

@NicolasGuilloux NicolasGuilloux commented Oct 22, 2024

Adding the aarch64-linux architecture for the Tarball build in the workflow actions.
Fixes #7

@tfc
Copy link
Owner

tfc commented Oct 22, 2024

Hey @NicolasGuilloux i updated to nixos-unstable, picked up your readme changes, but did the .github/workflows file change slightly differently and merged them to main. please let me know if i'm missing out anything. :)

@NicolasGuilloux NicolasGuilloux force-pushed the main branch 3 times, most recently from 9731ca4 to 39181d2 Compare October 22, 2024 15:30
@NicolasGuilloux
Copy link
Author

I rebased it.
But you did copy manually and partially the changes I made to support the aarch64 apparently.
Nonetheless there are some changes that are required to make it work, especially the extra_nix_config

Moreover, I think I fixed an issue since you are building the tarball with nixos-unstable, but specifying nixos-23.11 for the generated configuration.nix file.

@tfc
Copy link
Owner

tfc commented Oct 22, 2024

You're right, i forgot to fix the flake input on the inner flake template file.

However, i don't understand why you remove the caching parts in the github workflow description.

@tfc
Copy link
Owner

tfc commented Oct 22, 2024

and i see that somehow the "co-authored" line vanished when i cherry-picked your readme changes. this seems to be my fault. i can rebase with a corrected git commit message if you like.

@NicolasGuilloux
Copy link
Author

No I don't mind, it is just more simple to simply ask for changes and click on Merge ^^
True for the caching part, I failed to remember why I removed it. Let me try with it then.

@NicolasGuilloux NicolasGuilloux force-pushed the main branch 2 times, most recently from 250286d to bf43ae9 Compare October 22, 2024 16:14
@NicolasGuilloux
Copy link
Author

I found the option for the DeterminatesSystems action to support aarch64 build. The cache wasn't working properly with the cachix thing.
Everything should work well now, you can merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using nspawn-nixos on Unifi devices
2 participants