exit main thread with same exit code as payment_producer

[nicolasochem]

#679 introduced support for exit codes, so an alert can be sent in single-shot mode when payouts fail for any reason.

However, it was crude, only supporting exit code 1.

The producer thread supports many exit codes.

In this case, there is a benign issue where tzkt returns "not synced" and therefore payouts fail, but this is likely temporary and will pass at next try, so there is no need to alert. But, currently it's not possible to behave differently based on the exit code because it's always 0 or 1.

An ugly solution is to save the exit code of the child thread in a file, then read it in the main thread. That's what I am doing here. I remain convinced that the entire thread architecture needs to go away, and we need to make TRD single threaded again, but that's for another day.

Also:

• change the exit code of misconfigured provider to GENERAL_ERROR because it's not really a provider error,
• change the help to remove old providers that we don't support anymore

---

name: Pull Request
about: Create a pull request to make a contribution
labels:

---

IMPORTANT NOTICE:
I read and understood the guidelines for contributions to the TRD. The contribution may qualify for being compensated by the TRD grant if approved by the maintainers.

This PR resolves the issue . The following steps were performed:

• Analysis: If the described issue is a bug report, analyze the reasons resulting in this bug.

• Solution: Describe the proposed solution for the bug or feature.

• Implementation: Rough description/explanation of the implementation choices.

• Performed tests: Describe the performed tests.

• Documentation: Make sure to document the added changes in a proper way (Readme, help section, documentation, comments in code if needed)

• Check list:

• I extended the Github Actions CI test units with the corresponding tests for this new feature (if needed).
• I extended the Sphinx documentation (if needed).
• I extended the help section (if needed).
• I changed the README file (if needed).
• I created a new issue if there is further work left to be done (if needed).

Work effort: Give your estimate of the work effort in hours. This might be adjusted or discussed by the other contributors in order to keep a fair rewarding process for the efforts.

[TPXP]

Writing the exit code to a temporary file is a bit odd, can't we use a singleton python module to store this data?

Here's a basic implementation

# exit_code.py
exitCode = -1
exitOrigin = ""

def set_exit_code(origin: str, code: int):
  # Alternatively, use inspect.stack to get the caller details https://stackoverflow.com/questions/1095543/get-name-of-calling-functions-module-in-python
  if exitOrigin == "":
    exitCode = code
    exitOrigin = origin
  else:
    logger.warn(f"{origin} tried to set exit code to {code} while it had already been set by {exitOrigin} to {exitCode}. Ignoring")

def get_exit_code() -> int:
  return exitCode

Usage:

from exit_code import set_exit_code

# ... function code ...
set_exit_code("module.my_function", 3)

[puppetninja]

remove NOCHEM ?