Set saveClearedText to false by default #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`saveClearedText` should have been `false` by default to begin with. When false, `clearScreen` dumps all the data it clears from `#divOutput`. When true, a class is used to hide the data and preserve it to be displayed using `showScrollback`. This also changes the display settings of the pop-up dialog displayed by `showScrollback` to fullscreen, so things will work properly regardless of screen dimensions. NOTE: The change to `clearScreen` accidentally fixed an issue with `getCurrentDiv` in the WebPlayer. This will 're-introduce' that issue, but I will create an Issue to log that.
alexwarren
approved these changes
Dec 30, 2024
KVonGit
added a commit
to KVonGit/quest
that referenced
this pull request
Dec 31, 2024
- Remove HTML elements created for the pop-up dialog, as they each have an ID and will likely be created more than once - Change width and height of pop-up dialog for "scrollback" to be slightly smaller than the inner width and height of the window - Formatting Follow up to textadventures#1323
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
saveClearedText(added in Quest 5.8) should have beenfalseby default to begin with.When false,
clearScreendumps all the data it clears from#divOutput. When true, a class is used to hide the data and preserve it to be displayed usingshowScrollback.This also changes the display settings of the pop-up dialog displayed by
showScrollbackto fullscreen, so things will work properly regardless of screen dimensions.NOTE: The change to
clearScreenaccidentally fixed an issue withgetCurrentDiv. This will 're-introduce' that issue, but I will create an Issue to log that.ALSO NOTE: This PR will, in fact, resolve an issue if merged, but we are also considering removing this functionality, in which case this PR merely illustrates the issue with
clearScreen.