-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with enter_verb pattern type #1319
Conversation
What does "enter" clash with in the first place? |
The room quest/EditorControllerTests/EditorControllerTests.cs Lines 82 to 85 in bd8257b
|
<!-- Need a special verb in English because of the name collision with the "enter" script rooms use --> | ||
<verb name="enter_verb"> | ||
<pattern>enter #object#</pattern> | ||
<property>enterverb</property> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this be a breaking change for people upgrading, as enterverb
is now enter_verb
? Or does it not matter because this wasn't working in the first place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I thought I fixed that back to enterverb
! I see I failed to push the commit... One sec...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Good catch! GitHub Desktop was just sitting there, waiting for me to push that commit.
Got it. I guess ideally we might rename this for rooms to |
The last commit changed `enterverb` to `enter_verb`, which would break 5.8 works in progress.
Closes #1121
https://textadventures.co.uk/forum/samples/topic/-ygnjpim-kmbpbj44zznva/attention-quest-authors-who-use-the-enter-verb#c959d61d-235e-4d4e-b9a8-73e1dbd73fcb