Skip to content

Sync branches #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 45 commits into from
Jan 13, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
dcad61a
Handle when `geometry` is not a symbol (#4127)
yutannihilation Jul 10, 2020
325aef2
Warn too many breaks before doing `seq()` (#4132)
yutannihilation Jul 11, 2020
800af57
Document computed variable `width` and add a test (#4130)
yutannihilation Jul 11, 2020
2ac58ca
Document flipped computed variables (#4128)
yutannihilation Jul 12, 2020
cc7ac3b
WIP: Add scale_color_viridis_b (#4048)
xvrdm Jul 12, 2020
4a8c827
Refer to ggplot_global to reduce duplicated codes (#4129)
yutannihilation Jul 13, 2020
a3019f9
Regenerate document and add a test to ensure no missing scale_color_*…
yutannihilation Jul 13, 2020
c131022
typos; stick to en-GB; prefer project to website (#4145)
stragu Jul 25, 2020
8f7b03c
Fix CI failures (#4147)
yutannihilation Jul 28, 2020
b4bc293
Update pkgdown GitHub Action (#4151)
yutannihilation Jul 29, 2020
ca747d8
Fix discrete orientation example in stat_summary (#4152)
margoal1 Jul 30, 2020
5999889
Fix a typo in pr-command.yaml (#4153)
yutannihilation Jul 30, 2020
65ecdc1
Corrected type: cobination -> combination (#4156)
orrymr Aug 2, 2020
f0e561e
Update pr-commnads.yaml to the latest (#4157)
yutannihilation Aug 2, 2020
ca24e27
Update stat_ecdf to work either on the x or the y aesthetic. (#4005)
jgjl Aug 4, 2020
6d91349
Docs no longer say Geoms don't have setup_params() method (#4161)
burchill Aug 4, 2020
3be0acc
Update limits.r (#4171)
ismayc Aug 14, 2020
813d0bd
Set file background from plot theme (#4164)
karawoo Aug 20, 2020
6b8dba0
Avoid "<empty>" labels with qplot() (#4191)
yutannihilation Sep 6, 2020
ac2b5a7
Fix CI by skipping visual tests when vdiffr is not available (#4192)
yutannihilation Sep 6, 2020
9741da5
Add `oob` arguments to date/datetime position scales. (#4229)
teunbrand Oct 15, 2020
d700a0b
Add missing period at the end of sentence (#4227)
mine-cetinkaya-rundel Oct 15, 2020
8aead50
added to scale-hue.r documentation to explain behavior when using nam…
vinay-swamy Oct 18, 2020
7e51849
Do not use RStudio Package Manager for R-devel (#4242)
yutannihilation Oct 22, 2020
a132727
Fix saving plots with no background (#4244)
karawoo Oct 28, 2020
b76fa96
Drop support for R 3.2 (#4266)
yutannihilation Nov 16, 2020
12e61df
Clarify that span is only used for loess in stat_smooth (#4261)
nalimilan Nov 27, 2020
e60a3b9
Update documentation to midwest variables (#4274)
erictleung Dec 2, 2020
b5cc4d6
Fix geom_polygon default colour to NA (#4279) (#4282)
mdlama Dec 3, 2020
5d72f63
Compare facet params instead of the whole objects (#4294)
yutannihilation Dec 9, 2020
d9c902b
Compare facet params instead of the whole objects (#4294)
yutannihilation Dec 9, 2020
e9c96e4
Fix CI by skipping visual tests when vdiffr is not available (#4192)
yutannihilation Sep 6, 2020
1edc33a
Update license to MIT
thomasp85 Dec 14, 2020
9deb97b
Describe what is ymin, ymax (#4215)
llrs Dec 14, 2020
047bb56
Fix links
thomasp85 Dec 17, 2020
bab235c
polish news
thomasp85 Dec 17, 2020
239047b
update cran comments
thomasp85 Dec 17, 2020
593cac5
Increment version number
thomasp85 Dec 17, 2020
feaa4bc
Fixed typo in map_data() documentation (#4278) (#4303)
heathgilham Dec 28, 2020
c70ef2a
Allow trailing commas in guides() and labs() (#4240)
yutannihilation Jan 4, 2021
79a3f90
Increment version number
thomasp85 Jan 4, 2021
3df083c
Merge branch 'master' into v3.3.3-rc
thomasp85 Jan 4, 2021
6c85a6f
Merge 3.3.3 release into master
thomasp85 Jan 4, 2021
0394b9f
Update link formatting in readme
thomasp85 Jan 4, 2021
37eb64d
Toggle the logic of skipping visual tests (#4310)
yutannihilation Jan 8, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 15 additions & 29 deletions .github/workflows/R-CMD-check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ name: R-CMD-check

# Increment this version when we want to clear cache
env:
cache-version: v3
cache-version: v4

jobs:
R-CMD-check:
Expand All @@ -24,17 +24,16 @@ jobs:
config:
- {os: windows-latest, r: '4.0', vdiffr: true, xref: true}
- {os: macOS-latest, r: '4.0', vdiffr: true, xref: true}
- {os: macOS-latest, r: 'devel', vdiffr: false, xref: true}
- {os: ubuntu-16.04, r: '4.0', vdiffr: true, xref: true, cran: "https://demo.rstudiopm.com/all/__linux__/xenial/latest"}
- {os: ubuntu-16.04, r: '3.6', vdiffr: false, xref: true, cran: "https://demo.rstudiopm.com/all/__linux__/xenial/latest"}
- {os: ubuntu-16.04, r: '3.5', vdiffr: false, xref: true, cran: "https://demo.rstudiopm.com/all/__linux__/xenial/latest"}
- {os: ubuntu-16.04, r: '3.4', vdiffr: false, xref: true, cran: "https://demo.rstudiopm.com/all/__linux__/xenial/latest"}
- {os: ubuntu-16.04, r: '3.3', vdiffr: false, xref: true, cran: "https://demo.rstudiopm.com/all/__linux__/xenial/latest"}
- {os: ubuntu-16.04, r: '3.2', vdiffr: false, xref: false, cran: "https://demo.rstudiopm.com/all/__linux__/xenial/latest"}
- {os: ubuntu-16.04, r: 'devel', vdiffr: false, xref: true}
- {os: ubuntu-16.04, r: '4.0', vdiffr: true, xref: true, rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest"}
- {os: ubuntu-16.04, r: '3.6', vdiffr: false, xref: true, rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest"}
- {os: ubuntu-16.04, r: '3.5', vdiffr: false, xref: true, rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest"}
- {os: ubuntu-16.04, r: '3.4', vdiffr: false, xref: true, rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest"}
- {os: ubuntu-16.04, r: '3.3', vdiffr: false, xref: true, rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest"}

env:
R_REMOTES_NO_ERRORS_FROM_WARNINGS: true
CRAN: ${{ matrix.config.cran }}
RSPM: ${{ matrix.config.rspm }}
# don't treat missing suggested packages as error
_R_CHECK_FORCE_SUGGESTS_: false
# Some packages might unavailable on the older versions, so let's ignore xref warnings
Expand All @@ -49,6 +48,7 @@ jobs:
- uses: r-lib/actions/setup-r@master
with:
r-version: ${{ matrix.config.r }}
http-user-agent: ${{ matrix.config.http-user-agent }}

- uses: r-lib/actions/setup-pandoc@master

Expand All @@ -68,34 +68,20 @@ jobs:

- name: Install system dependencies on Linux
if: runner.os == 'Linux'
env:
RHUB_PLATFORM: linux-x86_64-ubuntu-gcc
run: |
# Use cran:libgit2 PPA to avoid conflicts of libcurl4-gnutls-dev
# Remove this after https://github.com/r-lib/actions/pull/97 gets merged
sudo add-apt-repository ppa:cran/libgit2

Rscript -e "remotes::install_github('r-hub/sysreqs')"
sysreqs=$(Rscript -e "cat(sysreqs::sysreq_commands('DESCRIPTION'))")
sudo -s eval "$sysreqs"
while read -r cmd
do
eval sudo $cmd
done < <(Rscript -e 'writeLines(remotes::system_requirements("ubuntu", "16.04"))')

- name: Install system dependencies on macOS
if: runner.os == 'macOS'
run: |
# XQuartz is needed by vdiffr
brew cask install xquartz

# To install vdiffr, these three libraries/tools are needed in addition to XQuartz
# - freetype (already installed, needed by systemfonts)
# - cairo (not installed, needed by gdtools)
# - pkg-config (not installed, needed to set proper build settings)
brew install pkg-config cairo

# Since sf dependencies are a bit heavy, install them only when they are needed
SF_NEEDS_UPDATED=$(Rscript -e 'if (!"sf" %in% installed.packages()[,"Package"] || "sf" %in% old.packages()[,"Package"]) cat("yes")')
if [ "${SF_NEEDS_UPDATED}" == "yes" ]; then
brew install udunits gdal
fi
# Use only binary packages
echo 'options(pkgType = "binary")' >> ~/.Rprofile

- name: Install dependencies
run: |
Expand Down
30 changes: 26 additions & 4 deletions .github/workflows/pkgdown.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,41 @@ name: pkgdown
jobs:
pkgdown:
runs-on: macOS-latest
env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
steps:
- uses: actions/checkout@v2

- uses: r-lib/actions/setup-r@master

- uses: r-lib/actions/setup-pandoc@master

- name: Query dependencies
run: |
install.packages('remotes')
saveRDS(remotes::dev_package_deps(dependencies = TRUE), ".github/depends.Rds", version = 2)
writeLines(sprintf("R-%i.%i", getRversion()$major, getRversion()$minor), ".github/R-version")
shell: Rscript {0}

- name: Cache R packages
uses: actions/cache@v1
with:
path: ${{ env.R_LIBS_USER }}
key: ${{ runner.os }}-${{ hashFiles('.github/R-version') }}-1-${{ hashFiles('.github/depends.Rds') }}
restore-keys: ${{ runner.os }}-${{ hashFiles('.github/R-version') }}-1-

- name: Install dependencies
run: |
install.packages("remotes")
remotes::install_deps(dependencies = TRUE)
remotes::install_deps(dependencies = TRUE, type = "binary")
remotes::install_github("tidyverse/tidytemplate")
remotes::install_dev("pkgdown")
shell: Rscript {0}

- name: Install package
run: R CMD INSTALL .

- name: Deploy package
run: pkgdown::deploy_to_branch(new_process = FALSE)
shell: Rscript {0}
run: |
git config --local user.email "actions@github.com"
git config --local user.name "GitHub Actions"
Rscript -e 'pkgdown::deploy_to_branch(new_process = FALSE)'
15 changes: 9 additions & 6 deletions .github/workflows/pr-commands.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,22 @@ jobs:
if: startsWith(github.event.comment.body, '/document')
name: document
runs-on: macOS-latest
env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
steps:
- uses: actions/checkout@v2
- uses: r-lib/actions/pr-fetch@master
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
- uses: r-lib/actions/setup-r@master
- name: Install dependencies
run: Rscript -e 'install.packages(c("remotes", "roxygen2"))' -e 'remotes::install_deps(dependencies = TRUE)'
run: Rscript -e 'install.packages(c("remotes", "roxygen2"))' -e 'remotes::install_deps(dependencies = TRUE, type = "binary")'
- name: Document
run: Rscript -e 'roxygen2::roxygenise()'
- name: commit
run: |
git config --local user.email "actions@github.com"
git config --local user.name "GitHub Actions"
git add man/\* NAMESPACE
git commit -m 'Document'
- uses: r-lib/actions/pr-push@master
Expand All @@ -28,6 +32,8 @@ jobs:
if: startsWith(github.event.comment.body, '/style')
name: style
runs-on: macOS-latest
env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
steps:
- uses: actions/checkout@v2
- uses: r-lib/actions/pr-fetch@master
Expand All @@ -40,13 +46,10 @@ jobs:
run: Rscript -e 'styler::style_pkg()'
- name: commit
run: |
git config --local user.email "actions@github.com"
git config --local user.name "GitHub Actions"
git add \*.R
git commit -m 'Style'
- uses: r-lib/actions/pr-push@master
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
# A mock job just to ensure we have a successful build status
finish:
runs-on: ubuntu-latest
steps:
- run: true
15 changes: 1 addition & 14 deletions .github/workflows/test-coverage.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,27 +39,14 @@ jobs:
restore-keys: ${{ env.cache-version }}-macOS-r-${{ env.r-version }}-

- name: Install system dependencies on macOS
if: runner.os == 'macOS'
run: |
# XQuartz is needed by vdiffr
brew cask install xquartz

# To install vdiffr, these three libraries/tools are needed in addition to XQuartz
# - freetype (already installed, needed by systemfonts)
# - cairo (not installed, needed by gdtools)
# - pkg-config (not installed, needed to set proper build settings)
brew install pkg-config cairo

# Since sf dependencies are a bit heavy, install them only when they are needed
SF_NEEDS_UPDATED=$(Rscript -e 'if (!"sf" %in% installed.packages()[,"Package"] || "sf" %in% old.packages()[,"Package"]) cat("yes")')
if [ "${SF_NEEDS_UPDATED}" == "yes" ]; then
brew install udunits gdal
fi

- name: Install dependencies
run: |
install.packages(c("remotes"))
remotes::install_deps(dependencies = TRUE)
remotes::install_deps(dependencies = TRUE, type = "binary")
remotes::install_cran("covr")
shell: Rscript {0}

Expand Down
13 changes: 7 additions & 6 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Package: ggplot2
Version: 3.3.2.9000
Version: 3.3.3.9000
Title: Create Elegant Data Visualisations Using the Grammar of Graphics
Description: A system for 'declaratively' creating graphics,
based on "The Grammar of Graphics". You provide the data, tell 'ggplot2'
Expand All @@ -25,7 +25,7 @@ Authors@R: c(
person("RStudio", role = c("cph", "fnd"))
)
Depends:
R (>= 3.2)
R (>= 3.3)
Imports:
digest,
glue,
Expand Down Expand Up @@ -63,10 +63,11 @@ Suggests:
sf (>= 0.7-3),
svglite (>= 1.2.0.9001),
testthat (>= 2.1.0),
vdiffr (>= 0.3.0)
vdiffr (>= 0.3.0),
xml2
Enhances: sp
License: GPL-2 | file LICENSE
URL: http://ggplot2.tidyverse.org, https://github.com/tidyverse/ggplot2
License: MIT + file LICENSE
URL: https://ggplot2.tidyverse.org, https://github.com/tidyverse/ggplot2
BugReports: https://github.com/tidyverse/ggplot2/issues
LazyData: true
Collate:
Expand Down Expand Up @@ -263,6 +264,6 @@ Collate:
'zxx.r'
'zzz.r'
VignetteBuilder: knitr
RoxygenNote: 7.1.0.9000
RoxygenNote: 7.1.1
Roxygen: list(markdown = TRUE)
Encoding: UTF-8
Loading