Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagates api.Memory.Grow by users to ModuleEngine #2216

Merged
merged 2 commits into from
May 27, 2024
Merged

Conversation

mathetake
Copy link
Member

Since the introduction of optimizing compiler, the Memory.Grow by the users,
which has the different call path than memory.grow instruction, didn't propagate
the growth result onto compiler's ModuleInstance.

Fixes #2215

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@mathetake mathetake marked this pull request as ready for review May 27, 2024 01:23
@mathetake mathetake merged commit 4dfb1f5 into main May 27, 2024
64 checks passed
@mathetake mathetake deleted the grownmemory branch May 27, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unreachable error and stack trace if compiled and extra memory, not otherwise
1 participant