Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wazevo(docs): optimizing compiler #2065

Merged
merged 8 commits into from
Mar 9, 2024
Merged

wazevo(docs): optimizing compiler #2065

merged 8 commits into from
Mar 9, 2024

Conversation

evacchi
Copy link
Contributor

@evacchi evacchi commented Feb 16, 2024

This PR introduces new, extensive documentation with details on how the new compiler works.

Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
@mathetake
Copy link
Member

will review tomorrow

@mathetake
Copy link
Member

mathetake commented Mar 6, 2024

preview url: https://deploy-preview-2065--wazero.netlify.app/

fyi I can't find the rendered pages on the website

Copy link
Member

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! I left some comments but looking fantastic overall

Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>

Co-authored-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@evacchi
Copy link
Contributor Author

evacchi commented Mar 6, 2024

fyi I can't find the rendered pages on the website

Yeah I didn't add a link anywhere yet 😬 but it's here https://deploy-preview-2065--wazero.netlify.app/docs/how_the_optimizing_compiler_works/frontend/

Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Comment on lines +146 to +147
magnitude (10x) or more, and therefore enabled by default whenever available. You can read more about wazero's
[optimizing compiler in the detailed documentation]({{< relref "/how_the_optimizing_compiler_works" >}}).
Copy link
Contributor Author

@evacchi evacchi Mar 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @mathetake added a link to the new section here

@mathetake
Copy link
Member

💯

@mathetake mathetake merged commit b7b54d5 into main Mar 9, 2024
1 check passed
@mathetake mathetake deleted the docs branch March 9, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants