Skip to content

feat[notask]: add QIP proposal skills#2277

Merged
yuranich merged 19 commits into
tetherto:mainfrom
yuranich:feature-qip-skills
Jun 10, 2026
Merged

feat[notask]: add QIP proposal skills#2277
yuranich merged 19 commits into
tetherto:mainfrom
yuranich:feature-qip-skills

Conversation

@yuranich

@yuranich yuranich commented May 26, 2026

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Teams need lightweight AI help for deciding exactly which improvement changes need QIPs, shaping proposal drafts for iteration, and reviewing QIPs before Slack Canvas approval without recreating the rejected ADR automation process.

How does it solve it?

Adds Cursor skills for conservative QIP significance checks, proposal drafting, and proposal review, plus a small non-eager rule nudge and skill catalog entries. The significance check now identifies exact QIP-worthy points and whether they belong in one proposal or several. The drafting skill now saves non-trivial drafts as markdown files, writes Solution sections as design explanations instead of task lists, and treats the template Risks section as consequences and trade-offs for proposal review.

Breaking changes

None.

Validation

  • ReadLints reported no issues for the updated QIP skill files.
  • git diff --check HEAD~1..HEAD passed for the latest commit.

Demo

https://drive.google.com/file/d/1opVhdulcFYOTaLdEX_ygTCdwRjj2Dsdx/view?usp=sharing

@yuranich yuranich marked this pull request as ready for review June 2, 2026 16:36
@yuranich yuranich requested review from a team as code owners June 2, 2026 16:37
NamelsKing
NamelsKing previously approved these changes Jun 4, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
@yuranich yuranich added the verified Authorize secrets / label-gate in PR workflows label Jun 5, 2026
Comment thread .cursor/rules/qip-triage.mdc
Comment thread .cursor/rules/qip-triage.mdc
darkynt
darkynt previously approved these changes Jun 10, 2026
Comment thread .cursor/skills/qv-qip-create/SKILL.md Outdated
Comment thread .cursor/skills/qv-qip-review/SKILL.md Outdated
lauripiisang
lauripiisang previously approved these changes Jun 10, 2026

@lauripiisang lauripiisang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, pending the testing shows it doesn't overtrigger or get in the way much -
Would appreciate some testing results in general of course.

@yuranich

Copy link
Copy Markdown
Contributor Author

/review

@github-actions

Copy link
Copy Markdown
Contributor

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ✅ APPROVED

**Requirements:**
- 1 Team Member approval ✅ (1/1)
- 1 Team Lead OR Management approval ✅ (1/1)



---
*This comment is automatically updated when reviews change.*

@yuranich yuranich merged commit fe70b65 into tetherto:main Jun 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

verified Authorize secrets / label-gate in PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants