feat[notask]: add QIP proposal skills#2277
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
NamelsKing
previously approved these changes
Jun 4, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
darkynt
previously approved these changes
Jun 10, 2026
lauripiisang
previously approved these changes
Jun 10, 2026
lauripiisang
left a comment
Contributor
There was a problem hiding this comment.
approved, pending the testing shows it doesn't overtrigger or get in the way much -
Would appreciate some testing results in general of course.
lauripiisang
approved these changes
Jun 10, 2026
opaninakuffo
approved these changes
Jun 10, 2026
Contributor
Author
|
/review |
Contributor
Tier-based Approval Status |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Teams need lightweight AI help for deciding exactly which improvement changes need QIPs, shaping proposal drafts for iteration, and reviewing QIPs before Slack Canvas approval without recreating the rejected ADR automation process.
How does it solve it?
Adds Cursor skills for conservative QIP significance checks, proposal drafting, and proposal review, plus a small non-eager rule nudge and skill catalog entries. The significance check now identifies exact QIP-worthy points and whether they belong in one proposal or several. The drafting skill now saves non-trivial drafts as markdown files, writes Solution sections as design explanations instead of task lists, and treats the template Risks section as consequences and trade-offs for proposal review.
Breaking changes
None.
Validation
ReadLintsreported no issues for the updated QIP skill files.git diff --check HEAD~1..HEADpassed for the latest commit.Demo
https://drive.google.com/file/d/1opVhdulcFYOTaLdEX_ygTCdwRjj2Dsdx/view?usp=sharing