Skip to content

npm install waits for nodejs install to finish#95

Merged
oxiez merged 3 commits into
masterfrom
FixNodeJS
Jul 25, 2019
Merged

npm install waits for nodejs install to finish#95
oxiez merged 3 commits into
masterfrom
FixNodeJS

Conversation

@oxiez

@oxiez oxiez commented Jul 24, 2019

Copy link
Copy Markdown
Collaborator

No description provided.

@oxiez oxiez requested review from gordom6 and jpmccu July 24, 2019 22:46
Comment thread manifests/install.pp Outdated
ensure => running,
subscribe => [File["/usr/share/jetty9/webapps/blazegraph/WEB-INF/GraphStore.properties"]],
} ->
exec { "wait_for_blazegrah":

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed?

@oxiez oxiez Jul 24, 2019

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't work (couldn't find for).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the previous ensure is good enough?

The for might need bash -c '' around it, to start a shell, if we still need the curl tries.

Comment thread manifests/install.pp Outdated
ensure => running,
subscribe => [File["/usr/share/jetty9/webapps/blazegraph/WEB-INF/GraphStore.properties"]],
} ->
exec { "wait_for_blazegrah":

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the previous ensure is good enough?

The for might need bash -c '' around it, to start a shell, if we still need the curl tries.

@oxiez oxiez merged commit 9277438 into master Jul 25, 2019
@oxiez oxiez deleted the FixNodeJS branch July 25, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants