Modify grading for incomplete chain. #2798
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified grading for incomplete chain
|
thanks! @magnuslarsen can you review this please? |
There was a problem hiding this comment.
Except for one extraneous comment, LGTM
Just to add some documentation:
Invalid certificates immediately results in zero score (T) - but later (2009i) incomplete chains were revised to a B
| @@ -7834,7 +7838,12 @@ determine_trust() { | |||
| if ! [[ ${certificate_file[i]} =~ Java ]]; then | |||
| # Exemption for Java AND rating, as this store doesn't seem to be as complete. | |||
| # We won't penalize this but we still need to raise a red flag. See #1648 | |||
| set_grade_cap "T" "Issues with chain of trust $code" | |||
| # set_grade_cap "T" "Issues with chain of trust $code" | |||
There was a problem hiding this comment.
No need for this comment
|
Thanks, @magnuslarsen 👍 Also there are additional white spaces
Could you take care of both issues @secinto ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified grading for incomplete chain
Describe your changes
SSLLabs doesn't give an T if the chain is incomplete but rather an B. Would be nice if we have the same grading here.
What is your pull request about?
If it's a code change please check the boxes which are applicable