-
Notifications
You must be signed in to change notification settings - Fork 18
bump mermaid to 11.12.2 #1374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump mermaid to 11.12.2 #1374
Conversation
# Conflicts: # znai-reactjs-api/README.md # znai-reactjs/package-lock.json # znai-reactjs/package.json # znai-reactjs/src/doc-elements/page/Page.jsx # znai-reactjs/src/doc-elements/search/SearchPopup.jsx # znai-reactjs/src/doc-elements/search/SearchPreview.jsx
|
here are the manual tests I am able to do
then run the CLI with this run configuration |
[Error] Failed to load resource: the server responded with a status of 500 (Internal Server Error) (search-index.js, line 0) [Error] SyntaxError: Importing binding name 'SearchResult' is not found.
|
At the moment in the javascript console there are these errors when running |
… index before the data is available
| @@ -1,35 +1,56 @@ | |||
| const React = require('react'); | |||
| /* | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we are touching this file for the first time since two sigma, please add znai maintainers 2025 to the copyright (see other files as an example)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deal with this comment on the other pull request #1384 .
znai-reactjs/pom.xml
Outdated
| <concat destfile="${project.build.outputDirectory}/static/main.js" append="true"> | ||
| <fileset file="dist/assets/index*.js" /> | ||
| </concat> | ||
| <echo file="${project.build.outputDirectory}/static/main.js" > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need this empty file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deal with this comment on the other pull request #1384.
# Conflicts: # znai-reactjs/src/doc-elements/cli/CliCommand.jsx # znai-reactjs/src/doc-elements/page/default/DefaultPageContent.tsx
Silence some typescript warnings generating red lines in IntelliJ
…WO SIGMA copyright in modified files.
# Conflicts: # znai-reactjs/package-lock.json
# Conflicts: # znai-reactjs/package-lock.json # znai-reactjs/package.json # znai-reactjs/src/doc-elements/text-selection/SlackActiveQuestions.tsx
# Conflicts: # znai-reactjs/package-lock.json # znai-reactjs/src/doc-elements/mermaid/Mermaid.demo.tsx
This pull request is now ready.
This pull request is a superset of #1384 .
Before upgrading vite and using the new roll down the following errors were happening with the new version of mermaid.
on FireFox
Fixes #1373