Skip to content

Improve local build documentation and fix build issue #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MykolaGolubyev merged 4 commits into from
Jan 18, 2025
Merged

Improve local build documentation and fix build issue #1273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
47deef3
updating local build instructions and maven compiler plugin version
antoinell Jan 1, 2025
37aae6b
adding a reference to firefox for the tests
antoinell Jan 2, 2025
9cc2867
fix issue where node is not found in typescript tests
antoinell Jan 2, 2025
996f8c6
Merge branch 'master' into build_update
MykolaGolubyev Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<maven.compiler.release>17</maven.compiler.release>
<groovy.version>3.0.15</groovy.version>
<vertx.io.version>3.9.4</vertx.io.version>
<commonmark.version>0.23.0</commonmark.version>
Expand All @@ -157,6 +156,7 @@
<jakarta.xml.bind-api.version>2.3.3</jakarta.xml.bind-api.version>
<httpcore.version>4.4.13</httpcore.version>
<httpclient.version>4.5.13</httpclient.version>
<frontend-maven-plugin.installDirectory>.mvn</frontend-maven-plugin.installDirectory>
</properties>

<dependencyManagement>
Expand Down Expand Up @@ -433,8 +433,9 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.11.0</version>
<version>3.13.0</version>
<configuration>
<release>17</release>
<source>17</source>
<target>17</target>
</configuration>
Expand Down Expand Up @@ -514,7 +515,7 @@
</executions>
<configuration>
<nodeVersion>v12.16.3</nodeVersion>
<installDirectory>.mvn</installDirectory>
<installDirectory>${frontend-maven-plugin.installDirectory}</installDirectory>
<workingDirectory>src</workingDirectory>
</configuration>
</plugin>
Expand Down
18 changes: 16 additions & 2 deletions znai-docs/znai/znai-development/local-build.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ Easy way to maintain Java specific dependencies below is by using [SDKMAN](https

## Java And Maven

You need Java 8 and Maven to build Znai.
You need Java 17 and Maven to build Znai.

```cli
sdk install java 8.0.342-amzn
sdk install java 17.0.13-amzn
sdk install maven
```

Expand All @@ -29,6 +29,20 @@ Use [brew](https://brew.sh) to install [GraphViz](http://www.graphviz.org/)
brew install graphviz
```

## Firefox

Some automated tests in znai are using [WebTau](https://testingisdocumenting.org/webtau/getting-started/what-is-this),
which in turn use Selenium WebDriver and firefox.

A firefox executable has to be on the system path.

Use [brew](https://brew.sh) to install [Firefox](https://www.mozilla.org/en-US/firefox/).

```cli
brew install firefox
```


# Build

```cli
Expand Down
9 changes: 9 additions & 0 deletions znai-typescript/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,15 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<systemPropertyVariables>
<node.bin>${project.basedir}/${frontend-maven-plugin.installDirectory}/node/node</node.bin>
</systemPropertyVariables>
</configuration>
</plugin>
</plugins>
</build>
</project>
Loading