Skip to content

Conversation

@vdsabev
Copy link
Contributor

@vdsabev vdsabev commented Nov 14, 2020

Hey folks! I'm just starting out with @testing-library/vue and since the README said You may also be interested in installing jest-dom I tried installing it, only to then find out it was moved to @testing-library/jest-dom, so I had to install the other one.

Perhaps this little change could save other people some time - I'd be happy if you considered accepting it.

Thanks for reading 😊

Instead of `jest-dom` which is now deprecated
@codecov
Copy link

codecov bot commented Nov 14, 2020

Codecov Report

Merging #172 (632546e) into master (8466f70) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #172   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           90        90           
  Branches        28        28           
=========================================
  Hits            90        90           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8466f70...632546e. Read the comment docs.

Copy link
Member

@afontcu afontcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@afontcu afontcu merged commit 53ff893 into testing-library:master Nov 14, 2020
@github-actions
Copy link

🎉 This PR is included in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

🎉 This PR is included in version 6.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants