Skip to content

[PoC] VTL@next: Update to Vue 3.0 and Vue Test Utils 2.0 #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 43 commits into from
Oct 31, 2020
Merged
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
c41507f
Bump Vue and VTU
afontcu Apr 27, 2020
a1b91ed
Identify TODOs
afontcu Apr 27, 2020
76c6624
Allow propsData (mark as breaking change)
afontcu Apr 27, 2020
ecfc251
Remove removed method
afontcu Apr 27, 2020
e9d5f95
Fix fire-event tests
afontcu Apr 27, 2020
9d1663e
Add basic TS config (is this needed?)
afontcu Apr 27, 2020
3659de3
Add link to related issue
afontcu Apr 27, 2020
e2ae9c8
Fix form.vue (not sure how this is related to Vue3?
afontcu Apr 27, 2020
75b58a2
Remove unrelated test – we need to add a cleaner way to test unmount
afontcu Apr 27, 2020
2175993
Fix inline snapshot
afontcu Apr 27, 2020
23730bc
Fix stubs test
afontcu Apr 27, 2020
ee56d98
Rename updateProps to setProps to align with VTU
afontcu Apr 27, 2020
8ab20b3
Bump deps
afontcu May 20, 2020
b2c597c
Silence third-party tests
afontcu May 20, 2020
fa3b7bf
Remove outdated comment
afontcu May 22, 2020
a1fca69
Comment out tests that relies on vue2 initialization and setting up
afontcu May 22, 2020
7af298a
Comment out vue-apollo (relies on vue2)
afontcu Jun 7, 2020
650ff5a
Comment out test that rely on vue2
afontcu Jun 8, 2020
09adb61
Comment out potential deprecated test
afontcu Jun 8, 2020
b80926b
Cleanup template
afontcu Jun 8, 2020
2b07210
Fix autocleanup tests
afontcu Jun 8, 2020
9e26a03
Fix warning on onsubmit jsdom
afontcu Aug 23, 2020
8483889
Bump vue deps
afontcu Aug 23, 2020
a333bba
Fix failing stubs tests
afontcu Aug 23, 2020
690df45
Update deps
afontcu Oct 9, 2020
553a8b0
Rename lifecycle method
afontcu Oct 9, 2020
1a6274d
Fix directive example
afontcu Oct 9, 2020
34e276e
Remove updateProps
afontcu Oct 9, 2020
e61a9ae
Simplify the slots example
afontcu Oct 9, 2020
347a30b
Fix functional tests
afontcu Oct 9, 2020
108b8b6
Add POC for Vuex 4
afontcu Oct 11, 2020
e8b1b02
Update vue-i18n example
afontcu Oct 11, 2020
49f6639
Fix snapshots
afontcu Oct 13, 2020
1496dd1
Fix vee-validate tests
afontcu Oct 13, 2020
90c3772
Add missing test for unmount
afontcu Oct 13, 2020
13497b3
Remove propsData
afontcu Oct 13, 2020
e054728
Remove isUnmounted
afontcu Oct 13, 2020
6e490c0
Add composition API example
afontcu Oct 13, 2020
5c98617
Bump deps
afontcu Oct 17, 2020
93768a4
Remove localVue references
afontcu Oct 17, 2020
47d3f0a
Bump vtu-next
afontcu Oct 18, 2020
8e06631
Comment out unused features (router)
afontcu Oct 18, 2020
38f53ae
Update deps
afontcu Oct 31, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix autocleanup tests
  • Loading branch information
afontcu committed Oct 31, 2020
commit 2b0721071a3de23d36f11bb622dba014ea092ed0
10 changes: 5 additions & 5 deletions src/vue-testing-library.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ function render(
const baseElement = customBaseElement || customContainer || document.body
const container = customContainer || baseElement.appendChild(div)

const attachTo = document.createElement('div')
container.appendChild(attachTo)

// const localVue = createLocalVue()
let vuexStore = null
let router = null
Expand Down Expand Up @@ -66,13 +63,16 @@ function render(
// localVue,
// router,
// store: vuexStore,
attachTo,
attachTo: container,
...mountOptions,
...additionalOptions,
})

mountedWrappers.add(wrapper)
container.appendChild(wrapper.element)

// hack to remove id="app"
// this fixes tests in auto-cleanup.js and auto-cleanup-skip.js
wrapper.parentElement.removeAttribute('id')

return {
container,
Expand Down