Skip to content

Conversation

@bozdoz
Copy link
Contributor

@bozdoz bozdoz commented Apr 16, 2021

What:

Fixes issues with pressing Space on a focused checkbox/radio input. Fixes tests for it.

Checklist:

  • Tests

Closes #653

@bozdoz bozdoz changed the title Fix to some tests with [Space] WIP: Fix to some tests with [Space] Apr 16, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 16, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a1f5be9:

Sandbox Source
userEvent-PR-template Configuration

@codecov
Copy link

codecov bot commented Apr 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@d22ea5e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             master      #654   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?        50           
  Lines             ?       922           
  Branches          ?       363           
==========================================
  Hits              ?       922           
  Misses            ?         0           
  Partials          ?         0           
Impacted Files Coverage Δ
src/utils/click/isClickableInput.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d22ea5e...a1f5be9. Read the comment docs.

@bozdoz bozdoz changed the title WIP: Fix to some tests with [Space] Fix to some tests with [Space] Apr 18, 2021
@bozdoz bozdoz changed the title Fix to some tests with [Space] Fix to some tests with [Space], Adds checkbox,radio to clickable inputs Apr 18, 2021
@ph-fritsche ph-fritsche merged commit 35d996e into testing-library:master Apr 18, 2021
@ph-fritsche
Copy link
Member

@all-contributors add @bozdoz bug, test

@allcontributors
Copy link
Contributor

@ph-fritsche

I've put up a pull request to add @bozdoz! 🎉

@github-actions
Copy link

🎉 This PR is included in version 13.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bozdoz bozdoz deleted the patch-2 branch April 19, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How should I test a Radio with onChange is called when Space is pressed?

2 participants