Skip to content

Conversation

@marcosvega91
Copy link
Member

What: run cypress on CI

Why: to be sure that e2e pass

How:

Checklist:

  • Tests
  • Ready to be merged

@smeijer smeijer merged commit fb43e61 into testing-library:develop Dec 7, 2020
@marcosvega91 marcosvega91 deleted the pr/add_cypress_on_ci branch December 7, 2020 16:08
@smeijer
Copy link
Member

smeijer commented Dec 9, 2020

@marcosvega91 , do you know why the test runner sometimes fails with UnhandledPromiseRejectionWarning: Error: inotify_add_watch failed: No space left on device.

For example: https://github.com/testing-library/testing-playground/runs/1524202360?check_suite_focus=true#step:3:116

@aganglada
Copy link
Collaborator

https://docs.cypress.io/guides/references/configuration.html#Videos

I think we might need to put videoUploadOnPasses: false on the config or not use the --record flag at all.

@smeijer
Copy link
Member

smeijer commented Dec 9, 2020

Worth a shot. Can we download videos? Otherwise we might want to disable it entirely.

@aganglada
Copy link
Collaborator

I don't think we can unless we ssh on the runner right? I'm not sure / don't know a lot about Github actions.
Can you confirm @marcosvega91?

@marcosvega91
Copy link
Member Author

marcosvega91 commented Dec 9, 2020

yes you can save videos and then you can download it, but we don't have an upload step. You can save them as artifacts.

The error is strange 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants