Skip to content

Conversation

@smeijer
Copy link
Member

@smeijer smeijer commented Jul 29, 2020

What:
Ooops, I killed the persistent highlight in #260. I should add tests 😞

Why:

How:

Checklist:

  • Tests
  • Ready to be merged

@smeijer smeijer added the bug Something isn't working label Jul 29, 2020
@smeijer smeijer self-assigned this Jul 29, 2020
@smeijer smeijer merged commit 301c638 into develop Jul 29, 2020
@smeijer smeijer deleted the feature/fix-highlight branch July 29, 2020 12:17
@delca85
Copy link
Member

delca85 commented Jul 29, 2020

Hi @smeijer !
Is https://develop.testing-playground.com/ always updated with the last merged branches? Because I'd like to test if the new changes affect some other behavior or not.

@smeijer
Copy link
Member Author

smeijer commented Jul 29, 2020

Hi @delca85!

Yes, develop.testing-playground.com is always updated with the last merged branches.

develop.testing-playground.com is running the develop branch.
testing-playground.com is running the live branch.

I've just updated the live version as well. So they are now both up-to-date.

Which behavior are you concerned about?

@delca85
Copy link
Member

delca85 commented Jul 29, 2020

Thanks for your reply.

I noticed a weird behavior when the Auto-run code mode is disabled.
The run button icon is always in refreshing state and I am not able to obtain the updated Preview from the new markup.

@smeijer
Copy link
Member Author

smeijer commented Jul 29, 2020

Is that with a specific markup / query?

@delca85
Copy link
Member

delca85 commented Jul 29, 2020

No, I am using the default one.

@smeijer
Copy link
Member Author

smeijer commented Jul 29, 2020

Should be fixed now

@delca85
Copy link
Member

delca85 commented Jul 29, 2020

Yes it is!

@smeijer
Copy link
Member Author

smeijer commented Jul 29, 2020

Thanks 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants