Skip to content

fix: apply sandboxing changes to embed mode #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: chore: push to production
merged 1 commit into from
Jun 26, 2020
Merged

fix: apply sandboxing changes to embed mode #221

merged 1 commit into from
Jun 26, 2020

Conversation

@smeijer
Copy link
Member

@smeijer smeijer commented Jun 26, 2020

What:
The recent changes to the sandboxing had broken the embed mode. This has been fixed

Why:
Embed mode was broken

How:

  • Communication through postMessage should target the parent frame, not just top.
  • The sandbox (iframe) is now always being rendered

Checklist:

  • Tests
  • Ready to be merged

@smeijer smeijer merged commit 0756d71 into develop Jun 26, 2020
@smeijer smeijer deleted the feature/fix-embed branch June 26, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@smeijer smeijer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@smeijer